Re: [Qemu-devel] [PATCH v4 15/35] tcg: Add CONFIG_ATOMIC64

2016-10-05 Thread Richard Henderson
On 10/04/2016 08:47 AM, Alex Bennée wrote: + char is_host64[sizeof(void *) >= sizeof(uint64_t) ? 1 : -1]; This breaks with --enable-werror (and my Travis images): config-temp/qemu-conf.c: In function ‘main’: config-temp/qemu-conf.c:12:8: error: unused variable ‘is_host64’ [-Werror=unused-va

Re: [Qemu-devel] [PATCH v4 15/35] tcg: Add CONFIG_ATOMIC64

2016-10-04 Thread Peter Maydell
On 4 October 2016 at 16:47, Alex Bennée wrote: > > Richard Henderson writes: >> >> +# >> +# See if 64-bit atomic operations are supported. >> +# Note that without __atomic builtins, we can only >> +# assume atomic loads/stores max at pointer size. >> + >> +

Re: [Qemu-devel] [PATCH v4 15/35] tcg: Add CONFIG_ATOMIC64

2016-10-04 Thread Alex Bennée
Richard Henderson writes: > Allow qemu to build on 32-bit hosts without 64-bit atomic ops. > > Even if we only allow 32-bit hosts to multi-thread emulate 32-bit > guests, we still need some way to handle the 32-bit guest using a > 64-bit atomic operation. Do so by dropping back to single-step.

[Qemu-devel] [PATCH v4 15/35] tcg: Add CONFIG_ATOMIC64

2016-09-16 Thread Richard Henderson
Allow qemu to build on 32-bit hosts without 64-bit atomic ops. Even if we only allow 32-bit hosts to multi-thread emulate 32-bit guests, we still need some way to handle the 32-bit guest using a 64-bit atomic operation. Do so by dropping back to single-step. Signed-off-by: Richard Henderson ---