Re: [Qemu-devel] [PATCH v4 12/21] target-arm: A64: Implement DC ZVA

2014-03-07 Thread Richard Henderson
On 03/07/2014 07:11 AM, Peter Maydell wrote: >> > As a bonus, you'll have accurate exceptions should the access throw, so you >> > don't need to force the save of PC before calling the helper. Which... I >> > don't >> > see you doing, so perhaps there's a bug here at the moment. > Mmm. (In system

Re: [Qemu-devel] [PATCH v4 12/21] target-arm: A64: Implement DC ZVA

2014-03-07 Thread Richard Henderson
On 03/07/2014 07:11 AM, Peter Maydell wrote: >> > cpu_stb_data doesn't take into account user vs kernel mode accesses. > ...so what does it use for the mmu index? > Oops, read the macro garbage incorrectly. It does make its way back to cpu_mmu_index. r~

Re: [Qemu-devel] [PATCH v4 12/21] target-arm: A64: Implement DC ZVA

2014-03-07 Thread Peter Maydell
On 7 March 2014 14:51, Richard Henderson wrote: > On 03/06/2014 11:32 AM, Peter Maydell wrote: >> +/** >> + * tlb_vaddr_to_host: >> + * @env: CPUArchState >> + * @addr: guest virtual address to look up >> + * @mmu_idx: MMU index to use for lookup >> + * >> + * Look up the specified guest virtual i

Re: [Qemu-devel] [PATCH v4 12/21] target-arm: A64: Implement DC ZVA

2014-03-07 Thread Richard Henderson
On 03/06/2014 11:32 AM, Peter Maydell wrote: > +/** > + * tlb_vaddr_to_host: > + * @env: CPUArchState > + * @addr: guest virtual address to look up > + * @mmu_idx: MMU index to use for lookup > + * > + * Look up the specified guest virtual index in the TCG softmmu TLB. > + * If the TLB contains a h

[Qemu-devel] [PATCH v4 12/21] target-arm: A64: Implement DC ZVA

2014-03-06 Thread Peter Maydell
Implement the DC ZVA instruction, which clears a block of memory. The fast path obtains a pointer to the underlying RAM via the TCG TLB data structure so we can do a direct memset(), with fallback to a simple byte-store loop in the slow path. Signed-off-by: Peter Maydell --- include/exec/softmmu