Re: [Qemu-devel] [PATCH v4 12/17] qapi: check invalid arguments on no-args commands

2016-08-18 Thread Marc-André Lureau
Hi On Thu, Aug 18, 2016 at 10:50 AM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Wed, Aug 17, 2016 at 6:49 PM Markus Armbruster > wrote: > > > >> marcandre.lur...@redhat.com writes: > >> > >> > From: Marc-André Lureau > >> > > >> > The generated marshal functions d

Re: [Qemu-devel] [PATCH v4 12/17] qapi: check invalid arguments on no-args commands

2016-08-17 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Wed, Aug 17, 2016 at 6:49 PM Markus Armbruster wrote: > >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > The generated marshal functions do not visit arguments from commands >> > that take no arguments. Thus they fail to catc

Re: [Qemu-devel] [PATCH v4 12/17] qapi: check invalid arguments on no-args commands

2016-08-17 Thread Marc-André Lureau
Hi On Wed, Aug 17, 2016 at 6:49 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > The generated marshal functions do not visit arguments from commands > > that take no arguments. Thus they fail to catch invalid > > members. Visit the argumen

Re: [Qemu-devel] [PATCH v4 12/17] qapi: check invalid arguments on no-args commands

2016-08-17 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > The generated marshal functions do not visit arguments from commands > that take no arguments. Thus they fail to catch invalid > members. Visit the arguments, if provided, to throw an error in case of > invalid members. > > Current

[Qemu-devel] [PATCH v4 12/17] qapi: check invalid arguments on no-args commands

2016-08-10 Thread marcandre . lureau
From: Marc-André Lureau The generated marshal functions do not visit arguments from commands that take no arguments. Thus they fail to catch invalid members. Visit the arguments, if provided, to throw an error in case of invalid members. Currently, qmp_check_client_args() checks for invalid argu