Re: [Qemu-devel] [PATCH v4 11/11] cputlb: modernise the debug support

2016-02-03 Thread Alex Bennée
Peter Maydell writes: > On 3 February 2016 at 18:54, Alex Bennée wrote: >> It preserves the old behaviour (and the general behaviour of DEBUG_FOO >> going to stderr). However I'm happy to make it default to using the log >> output. >> >> It does raise the question of if we should just enable th

Re: [Qemu-devel] [PATCH v4 11/11] cputlb: modernise the debug support

2016-02-03 Thread Peter Maydell
On 3 February 2016 at 18:54, Alex Bennée wrote: > It preserves the old behaviour (and the general behaviour of DEBUG_FOO > going to stderr). However I'm happy to make it default to using the log > output. > > It does raise the question of if we should just enable the debugging by > default? Not w

Re: [Qemu-devel] [PATCH v4 11/11] cputlb: modernise the debug support

2016-02-03 Thread Alex Bennée
Aurelien Jarno writes: > On 2015-08-03 10:14, Alex Bennée wrote: >> To avoid cluttering the code with #ifdef legs we wrap up the print >> statements into a tlb_debug() macro. As access to the virtual TLB can >> get quite heavy defining DEBUG_TLB_LOG will ensure all the logs go to >> the qemu_log

Re: [Qemu-devel] [PATCH v4 11/11] cputlb: modernise the debug support

2015-08-04 Thread Aurelien Jarno
On 2015-08-03 10:14, Alex Bennée wrote: > To avoid cluttering the code with #ifdef legs we wrap up the print > statements into a tlb_debug() macro. As access to the virtual TLB can > get quite heavy defining DEBUG_TLB_LOG will ensure all the logs go to > the qemu_log target of CPU_LOG_MMU instead o

[Qemu-devel] [PATCH v4 11/11] cputlb: modernise the debug support

2015-08-03 Thread Alex Bennée
To avoid cluttering the code with #ifdef legs we wrap up the print statements into a tlb_debug() macro. As access to the virtual TLB can get quite heavy defining DEBUG_TLB_LOG will ensure all the logs go to the qemu_log target of CPU_LOG_MMU instead of stderr. I've also removed DEBUG_TLB_CHECK whi