Re: [Qemu-devel] [PATCH v4 10/28] qmp: Improve QMP dispatch error messages

2017-03-07 Thread Philippe Mathieu-Daudé
On 03/07/2017 11:21 AM, Eric Blake wrote: On 03/05/2017 02:01 AM, Markus Armbruster wrote: Since substantial other work depends on this series, it needs to go in sooner rather than later. I'm therefore *dropping* this patch from the series. We can then bikeshed^Wpolish to our heart's content

Re: [Qemu-devel] [PATCH v4 10/28] qmp: Improve QMP dispatch error messages

2017-03-07 Thread Eric Blake
On 03/05/2017 02:01 AM, Markus Armbruster wrote: > Since substantial other work depends on this series, it needs to go in > sooner rather than later. I'm therefore *dropping* this patch from the > series. We can then bikeshed^Wpolish to our heart's content without > holding up other work. > > T

Re: [Qemu-devel] [PATCH v4 10/28] qmp: Improve QMP dispatch error messages

2017-03-06 Thread Markus Armbruster
Eric Blake writes: > On 03/05/2017 02:01 AM, Markus Armbruster wrote: > @@ -41,15 +41,17 @@ static QDict *qmp_dispatch_check_obj(const QObject *request, Error **errp) if (!strcmp(arg_name, "execute")) { if (qobject_type(arg_obj) != QTYPE_QSTRING) {

Re: [Qemu-devel] [PATCH v4 10/28] qmp: Improve QMP dispatch error messages

2017-03-06 Thread Eric Blake
On 03/05/2017 02:01 AM, Markus Armbruster wrote: >>> @@ -41,15 +41,17 @@ static QDict *qmp_dispatch_check_obj(const QObject >>> *request, Error **errp) >>> >>> if (!strcmp(arg_name, "execute")) { >>> if (qobject_type(arg_obj) != QTYPE_QSTRING) { >>> -error_se

Re: [Qemu-devel] [PATCH v4 10/28] qmp: Improve QMP dispatch error messages

2017-03-05 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi Markus, > > On 03/03/2017 09:32 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> --- >> qapi/qmp-dispatch.c | 14 -- >> 1 file changed, 8 insertions(+), 6 deletions(-) >> >> diff --git a/qapi/qmp-disp

Re: [Qemu-devel] [PATCH v4 10/28] qmp: Improve QMP dispatch error messages

2017-03-03 Thread Philippe Mathieu-Daudé
Hi Markus, On 03/03/2017 09:32 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qapi/qmp-dispatch.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index 23b0528..578c6d8 1006

[Qemu-devel] [PATCH v4 10/28] qmp: Improve QMP dispatch error messages

2017-03-03 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qapi/qmp-dispatch.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index 23b0528..578c6d8 100644 --- a/qapi/qmp-dispatch.c +++ b/qapi/qmp-dispatch.c @@ -30,7