Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-14 Thread Kevin Wolf
Am 14.03.2012 14:11, schrieb Eric Blake: >>> * We could use the transaction APIs without actually making it >>> transaction (if we fail in the middle we can't rollback). The only >>> advantage of this is that we'd provide a consistent API to libvirt >>> and we would postpone the problem to th

Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-14 Thread Federico Simoncelli
nt: Wednesday, March 14, 2012 10:34:08 AM > Subject: Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command > > > * We could leave it as it is, a distinct command that is not part > > of > > the transaction and that it's closing the old image before > > op

Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-14 Thread Eric Blake
On 03/14/2012 03:34 AM, Kevin Wolf wrote: >> That said, reopen is really hard to be implemented as a transaction >> without breaking that rule. For example in the blkmirror case you'd >> need to open the destination image in r/w while the mirroring is in >> action (already having the same image in

Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-14 Thread Kevin Wolf
Am 14.03.2012 10:19, schrieb Paolo Bonzini: > Il 14/03/2012 10:17, Kevin Wolf ha scritto: >> If we want to do this, it needs to be the same patch, as we couple the >> transaction actions with top-level commands as long as there is no other >> way to discover the possible actions. And it probably m

Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-14 Thread Kevin Wolf
com >> Sent: Tuesday, March 13, 2012 9:48:10 PM >> Subject: Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command >> >> On 03/06/2012 10:56 AM, Paolo Bonzini wrote: >>> From: Federico Simoncelli >>> >>> Signed-off-by: Federico Simoncelli &

Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 10:17, Kevin Wolf ha scritto: > If we want to do this, it needs to be the same patch, as we couple the > transaction actions with top-level commands as long as there is no other > way to discover the possible actions. And it probably makes more sense > anyway, because the top-level c

Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-14 Thread Kevin Wolf
Am 13.03.2012 21:48, schrieb Eric Blake: > On 03/06/2012 10:56 AM, Paolo Bonzini wrote: >> From: Federico Simoncelli >> >> Signed-off-by: Federico Simoncelli >> Signed-off-by: Paolo Bonzini > >> ## >> +# @drive-reopen >> +# >> +# Assigns a new image file to a device. >> +# >> +# @device: the n

Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-13 Thread Federico Simoncelli
- Original Message - > From: "Eric Blake" > To: "Paolo Bonzini" > Cc: kw...@redhat.com, fsimo...@redhat.com, qemu-devel@nongnu.org, > stefa...@linux.vnet.ibm.com, lcapitul...@redhat.com > Sent: Tuesday, March 13, 2012 9:48:10 PM > Subject: Re: [Qemu

Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-13 Thread Eric Blake
On 03/06/2012 10:56 AM, Paolo Bonzini wrote: > From: Federico Simoncelli > > Signed-off-by: Federico Simoncelli > Signed-off-by: Paolo Bonzini > ## > +# @drive-reopen > +# > +# Assigns a new image file to a device. > +# > +# @device: the name of the device for which we are changing the image

[Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

2012-03-06 Thread Paolo Bonzini
From: Federico Simoncelli Signed-off-by: Federico Simoncelli Signed-off-by: Paolo Bonzini --- blockdev.c | 63 ++ hmp-commands.hx | 16 + hmp.c| 11 + hmp.h|1 + qapi-schema.json |