Re: [Qemu-devel] [PATCH v4 1/8] apic: add global apic_get_class()

2016-10-07 Thread Peter Xu
On Wed, Oct 05, 2016 at 03:06:50PM +0200, Radim Krčmář wrote: > Every configuration has only up to one APIC class and we'll be extending > the class with a function that can be called without an instanced > object, so a direct access to the class is convenient. > > This patch will break compilatio

Re: [Qemu-devel] [PATCH v4 1/8] apic: add global apic_get_class()

2016-10-06 Thread Eduardo Habkost
On Wed, Oct 05, 2016 at 03:06:50PM +0200, Radim Krčmář wrote: > Every configuration has only up to one APIC class and we'll be extending > the class with a function that can be called without an instanced > object, so a direct access to the class is convenient. > > This patch will break compilatio

[Qemu-devel] [PATCH v4 1/8] apic: add global apic_get_class()

2016-10-05 Thread Radim Krčmář
Every configuration has only up to one APIC class and we'll be extending the class with a function that can be called without an instanced object, so a direct access to the class is convenient. This patch will break compilation if some code uses apic_get_class() with CONFIG_USER_ONLY. Suggested-b