Re: [Qemu-devel] [PATCH v4 1/3] qmp: Add command 'blockdev-backup'

2014-12-19 Thread Markus Armbruster
Max Reitz writes: > On 2014-12-04 at 03:29, Fam Zheng wrote: >> Similar to drive-backup, but this command uses a device id as target >> instead of creating/opening an image file. >> >> Also add blocker on target bs, since the target is also a named device >> now. >> >> Add check and report error

Re: [Qemu-devel] [PATCH v4 1/3] qmp: Add command 'blockdev-backup'

2014-12-05 Thread Max Reitz
On 2014-12-05 at 07:12, Fam Zheng wrote: On Thu, 12/04 14:43, Max Reitz wrote: +if (!bs) { +error_set(errp, QERR_DEVICE_NOT_FOUND, device); +return; +} + +target_bs = bdrv_find(target); +if (!target_bs) { +error_set(errp, QERR_DEVICE_NOT_FOUND, target); +

Re: [Qemu-devel] [PATCH v4 1/3] qmp: Add command 'blockdev-backup'

2014-12-04 Thread Fam Zheng
On Thu, 12/04 14:43, Max Reitz wrote: > >+if (!bs) { > >+error_set(errp, QERR_DEVICE_NOT_FOUND, device); > >+return; > >+} > >+ > >+target_bs = bdrv_find(target); > >+if (!target_bs) { > >+error_set(errp, QERR_DEVICE_NOT_FOUND, target); > >+return; >

Re: [Qemu-devel] [PATCH v4 1/3] qmp: Add command 'blockdev-backup'

2014-12-04 Thread Max Reitz
On 2014-12-04 at 03:29, Fam Zheng wrote: Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible

[Qemu-devel] [PATCH v4 1/3] qmp: Add command 'blockdev-backup'

2014-12-03 Thread Fam Zheng
Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible but is an illegal case with introduction of