Re: [Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migration support

2018-03-28 Thread Marc-André Lureau
Hi On Thu, Mar 1, 2018 at 8:59 PM, Stefan Berger wrote: > Extend the TPM emulator backend device with state migration support. > > The external TPM emulator 'swtpm' provides a protocol over > its control channel to retrieve its state blobs. We implement > functions for getting and setting the dif

Re: [Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migration support

2018-03-05 Thread Stefan Berger
On 03/02/2018 04:26 AM, Marc-André Lureau wrote: +return 0; +} + +static const VMStateDescription vmstate_tpm_emulator = { +.name = "tpm-emulator", +.version_id = 1, +.minimum_version_id = 0, version_id = 1 & minimum_version_id = 0 ? It's the first version, let's have version_

Re: [Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migration support

2018-03-05 Thread Stefan Berger
On 03/05/2018 07:43 AM, Dr. David Alan Gilbert wrote: * Stefan Berger (stef...@linux.vnet.ibm.com) wrote: On 03/02/2018 05:14 AM, Dr. David Alan Gilbert wrote: hw/tpm/tpm_emulator.c:909:tpm_emulator_class_init: Object 0x55f4cbc72680 is not an instance of type device Aborted Can we leave it as

Re: [Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migration support

2018-03-05 Thread Dr. David Alan Gilbert
* Stefan Berger (stef...@linux.vnet.ibm.com) wrote: > On 03/02/2018 05:14 AM, Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > Hi Stefan > > > > > > On Thu, Mar 1, 2018 at 8:59 PM, Stefan Berger > > > wrote: > > > > Extend the TPM emulator backend de

Re: [Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migration support

2018-03-02 Thread Stefan Berger
On 03/02/2018 05:14 AM, Dr. David Alan Gilbert wrote: * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: Hi Stefan On Thu, Mar 1, 2018 at 8:59 PM, Stefan Berger wrote: Extend the TPM emulator backend device with state migration support. The external TPM emulator 'swtpm' provides a proto

Re: [Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migration support

2018-03-02 Thread Stefan Berger
On 03/02/2018 04:26 AM, Marc-André Lureau wrote: Hi Stefan On Thu, Mar 1, 2018 at 8:59 PM, Stefan Berger wrote: Extend the TPM emulator backend device with state migration support. The external TPM emulator 'swtpm' provides a protocol over its control channel to retrieve its state blobs. We i

Re: [Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migration support

2018-03-02 Thread Stefan Berger
On 03/02/2018 04:26 AM, Marc-André Lureau wrote: Hi Stefan On Thu, Mar 1, 2018 at 8:59 PM, Stefan Berger wrote: Extend the TPM emulator backend device with state migration support. The external TPM emulator 'swtpm' provides a protocol over its control channel to retrieve its state blobs. We i

Re: [Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migration support

2018-03-02 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi Stefan > > On Thu, Mar 1, 2018 at 8:59 PM, Stefan Berger > wrote: > > Extend the TPM emulator backend device with state migration support. > > > > The external TPM emulator 'swtpm' provides a protocol over > > its control channel to ret

Re: [Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migration support

2018-03-02 Thread Marc-André Lureau
Hi Stefan On Thu, Mar 1, 2018 at 8:59 PM, Stefan Berger wrote: > Extend the TPM emulator backend device with state migration support. > > The external TPM emulator 'swtpm' provides a protocol over > its control channel to retrieve its state blobs. We implement > functions for getting and setting

[Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migration support

2018-03-01 Thread Stefan Berger
Extend the TPM emulator backend device with state migration support. The external TPM emulator 'swtpm' provides a protocol over its control channel to retrieve its state blobs. We implement functions for getting and setting the different state blobs. In case the setting of the state blobs fails, w