Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries

2015-06-02 Thread Paolo Bonzini
On 02/06/2015 17:30, Kirk Allan wrote: > I was assuming that if you set _WIN32_WINNT=0x0600 (needed to gain > access to the OnLinkPrefixLength field when running on Windows > Vista/2008 and greater) you would also want to set WINVER=0x600 to > match. Having WINVER in the flags as both 501 and 60

Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries

2015-06-02 Thread Kirk Allan
>>> > > On 01/06/2015 23:19, Kirk Allan wrote: >>> Elsewhere on the list, we've discussed putting extra cflags >>> _after_ the configure-detected QEMU_CFLAGS. This would fix the >>> issue in the first part of this patch too. >> >> By the time this portion of the configure script executes, an

Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries

2015-06-02 Thread Paolo Bonzini
On 01/06/2015 23:19, Kirk Allan wrote: >> Elsewhere on the list, we've discussed putting extra cflags >> _after_ the configure-detected QEMU_CFLAGS. This would fix the >> issue in the first part of this patch too. > > By the time this portion of the configure script executes, any > --extra-cfla

Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries

2015-06-01 Thread Kirk Allan
>>> > > On 01/06/2015 20:56, Kirk Allan wrote: >> Test if *-extra-cflags is being used to include flags such as >> _WIN32_WINVER and WINVER to gain additional functionality offered >> by Windows Vista/2008 and newer. If not, default WINVER to 0x501. >> >> Add the iphlpapi library to use APIs

Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries

2015-06-01 Thread Paolo Bonzini
On 01/06/2015 20:56, Kirk Allan wrote: > Test if –-extra-cflags is being used to include flags such as > _WIN32_WINVER and WINVER to gain additional functionality offered > by Windows Vista/2008 and newer. If not, default WINVER to 0x501. > > Add the iphlpapi library to use APIs such as GetAdap

Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries

2015-06-01 Thread Eric Blake
On 06/01/2015 12:56 PM, Kirk Allan wrote: > Test if –-extra-cflags is being used to include flags such as Something in your workflow is substituting UTF-8 characters instead of ASCII '-'. s/–-/--/ > _WIN32_WINVER and WINVER to gain additional functionality offered > by Windows Vista/2008 and new

[Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries

2015-06-01 Thread Kirk Allan
Test if –-extra-cflags is being used to include flags such as _WIN32_WINVER and WINVER to gain additional functionality offered by Windows Vista/2008 and newer. If not, default WINVER to 0x501. Add the iphlpapi library to use APIs such as GetAdaptersInfo and GetAdaptersAddresses. Signed-off-by: