Re: [Qemu-devel] [PATCH v4 1/2] hw/pci: fixed error flow in pci_qdev_init

2014-10-31 Thread Markus Armbruster
Marcel Apfelbaum writes: > Verify return code for pci_add_option_rom. > > Signed-off-by: Marcel Apfelbaum > --- > hw/pci/pci.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index 6ce75aa..36226eb 100644 > --- a/hw/pci/pci.c > +++ b/

Re: [Qemu-devel] [PATCH v4 1/2] hw/pci: fixed error flow in pci_qdev_init

2014-10-31 Thread Marcel Apfelbaum
On Thu, 2014-10-30 at 14:33 +0100, Markus Armbruster wrote: > Marcel Apfelbaum writes: > > > Verify return code for pci_add_option_rom. > > > > Signed-off-by: Marcel Apfelbaum > > --- > > hw/pci/pci.c | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/hw/pci/pc

[Qemu-devel] [PATCH v4 1/2] hw/pci: fixed error flow in pci_qdev_init

2014-10-27 Thread Marcel Apfelbaum
Verify return code for pci_add_option_rom. Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 6ce75aa..36226eb 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1776,7 +1776,12 @@ static int