Re: [Qemu-devel] [PATCH v4 09/11] sdcard: display protocol used when tracing

2018-03-03 Thread Philippe Mathieu-Daudé
On 02/22/2018 10:02 AM, Peter Maydell wrote: > On 15 February 2018 at 22:05, Philippe Mathieu-Daudé wrote: >> put the function in sdmmc-common.c since we will reuse it in hw/sd/core.c >> >> Signed-off-by: Philippe Mathieu-Daudé > > Commit message talks about a function but the patch doesn't > ad

Re: [Qemu-devel] [PATCH v4 09/11] sdcard: display protocol used when tracing

2018-02-22 Thread Peter Maydell
On 15 February 2018 at 22:05, Philippe Mathieu-Daudé wrote: > put the function in sdmmc-common.c since we will reuse it in hw/sd/core.c > > Signed-off-by: Philippe Mathieu-Daudé Commit message talks about a function but the patch doesn't add any new functions ? (Also, sentences should start with

[Qemu-devel] [PATCH v4 09/11] sdcard: display protocol used when tracing

2018-02-15 Thread Philippe Mathieu-Daudé
put the function in sdmmc-common.c since we will reuse it in hw/sd/core.c Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 14 ++ hw/sd/trace-events | 8 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 666ff3873f..