Re: [Qemu-devel] [PATCH v4 09/10] qga: process_event() simplification

2018-10-08 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > On Thu, Aug 30, 2018 at 6:03 PM Markus Armbruster wrote: >> >> Marc-André Lureau writes: >> >> > Simplify the code around qmp_dispatch(): >> > - rely on qmp_dispatch/check_obj() for message checking >> > - have a single send_response() point >> > - constify send

Re: [Qemu-devel] [PATCH v4 09/10] qga: process_event() simplification

2018-10-02 Thread Marc-André Lureau
Hi On Thu, Aug 30, 2018 at 6:03 PM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Simplify the code around qmp_dispatch(): > > - rely on qmp_dispatch/check_obj() for message checking > > - have a single send_response() point > > - constify send_response() argument > > > > It changes

Re: [Qemu-devel] [PATCH v4 09/10] qga: process_event() simplification

2018-08-30 Thread Markus Armbruster
Marc-André Lureau writes: > Simplify the code around qmp_dispatch(): > - rely on qmp_dispatch/check_obj() for message checking > - have a single send_response() point > - constify send_response() argument > > It changes a couple of error messages: > > * When @req isn't a dictionary, from > In

[Qemu-devel] [PATCH v4 09/10] qga: process_event() simplification

2018-08-29 Thread Marc-André Lureau
Simplify the code around qmp_dispatch(): - rely on qmp_dispatch/check_obj() for message checking - have a single send_response() point - constify send_response() argument It changes a couple of error messages: * When @req isn't a dictionary, from Invalid JSON syntax to QMP input must be