Re: [Qemu-devel] [PATCH v4 08/19] qapi: Better error messages for bad expressions

2014-09-26 Thread Markus Armbruster
Kevin Wolf writes: > Am 26.09.2014 um 11:15 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 24.09.2014 um 09:34 hat Markus Armbruster geschrieben: >> >> Eric Blake writes: >> >> >> >> > On 09/23/2014 08:56 AM, Markus Armbruster wrote: >> >> >> Eric Blake writes: >> >> >>>

Re: [Qemu-devel] [PATCH v4 08/19] qapi: Better error messages for bad expressions

2014-09-26 Thread Kevin Wolf
Am 26.09.2014 um 11:15 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 24.09.2014 um 09:34 hat Markus Armbruster geschrieben: > >> Eric Blake writes: > >> > >> > On 09/23/2014 08:56 AM, Markus Armbruster wrote: > >> >> Eric Blake writes: > >> >>> Add check_keys to cover these

Re: [Qemu-devel] [PATCH v4 08/19] qapi: Better error messages for bad expressions

2014-09-26 Thread Markus Armbruster
Kevin Wolf writes: > Am 24.09.2014 um 09:34 hat Markus Armbruster geschrieben: >> Eric Blake writes: >> >> > On 09/23/2014 08:56 AM, Markus Armbruster wrote: >> >> Eric Blake writes: >> >>> Add check_keys to cover these situations, and update testcases to >> >>> match. A couple other tests (e

Re: [Qemu-devel] [PATCH v4 08/19] qapi: Better error messages for bad expressions

2014-09-24 Thread Markus Armbruster
Kevin Wolf writes: > Am 24.09.2014 um 09:34 hat Markus Armbruster geschrieben: >> Eric Blake writes: >> >> > On 09/23/2014 08:56 AM, Markus Armbruster wrote: >> >> Eric Blake writes: >> >>> Add check_keys to cover these situations, and update testcases to >> >>> match. A couple other tests (e

Re: [Qemu-devel] [PATCH v4 08/19] qapi: Better error messages for bad expressions

2014-09-24 Thread Kevin Wolf
Am 24.09.2014 um 09:34 hat Markus Armbruster geschrieben: > Eric Blake writes: > > > On 09/23/2014 08:56 AM, Markus Armbruster wrote: > >> Eric Blake writes: > >>> Add check_keys to cover these situations, and update testcases to > >>> match. A couple other tests (enum-missing-data, indented-ex

Re: [Qemu-devel] [PATCH v4 08/19] qapi: Better error messages for bad expressions

2014-09-24 Thread Markus Armbruster
Eric Blake writes: > On 09/23/2014 08:56 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> The previous commit demonstrated that the generator overlooked some >>> fairly basic broken expressions: >>> - missing metataype >>> - metatype key has a non-string value >>> - unknown key in rela

Re: [Qemu-devel] [PATCH v4 08/19] qapi: Better error messages for bad expressions

2014-09-23 Thread Eric Blake
On 09/23/2014 08:56 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The previous commit demonstrated that the generator overlooked some >> fairly basic broken expressions: >> - missing metataype >> - metatype key has a non-string value >> - unknown key in relation to the metatype >> - conf

Re: [Qemu-devel] [PATCH v4 08/19] qapi: Better error messages for bad expressions

2014-09-23 Thread Markus Armbruster
Eric Blake writes: > The previous commit demonstrated that the generator overlooked some > fairly basic broken expressions: > - missing metataype > - metatype key has a non-string value > - unknown key in relation to the metatype > - conflicting metatype (this patch treats the second metatype as

[Qemu-devel] [PATCH v4 08/19] qapi: Better error messages for bad expressions

2014-09-19 Thread Eric Blake
The previous commit demonstrated that the generator overlooked some fairly basic broken expressions: - missing metataype - metatype key has a non-string value - unknown key in relation to the metatype - conflicting metatype (this patch treats the second metatype as an unknown key of the first key v