[Note Cc: Kevin]
Eric Blake writes:
> On 04/09/2013 11:23 AM, Markus Armbruster wrote:
>>> If we mandate that a tag always be supplied, then we cannot create qcow2
>>> files with a snapshot that lacks a tag using just QMP; but even if we do
>>
>> Are you sure you can do that with the proposed p
On 04/09/2013 11:23 AM, Markus Armbruster wrote:
>> If we mandate that a tag always be supplied, then we cannot create qcow2
>> files with a snapshot that lacks a tag using just QMP; but even if we do
>
> Are you sure you can do that with the proposed patches? If I read them
> correctly, we make
Eric Blake writes:
> On 04/09/2013 10:04 AM, Markus Armbruster wrote:
>
>>> +
>>> +##
>>> +# @vm-snapshot-save:
>>> +#
>>> +# Create a snapshot of the whole virtual machine. If tag is
>>> provided as @name,
>>> +# it is used as human readable identifier. If there is already a snapshot
>>> +# with
On 04/09/2013 10:04 AM, Markus Armbruster wrote:
>> +
>> +##
>> +# @vm-snapshot-save:
>> +#
>> +# Create a snapshot of the whole virtual machine. If tag is provided as
>> @name,
>> +# it is used as human readable identifier. If there is already a snapshot
>> +# with the same tag or id, the force
Patch no longer applies.
Pavel Hrdina writes:
> QMP command "vm-snapshot-save" has also extra optional force parameter
> to specify whether replace existing snapshot or not. It also returns
> information about created snapshot.
Took me a minute to realize that you're comparing it to HMP command
On 29.3.2013 17:12, Eric Blake wrote:
On 03/29/2013 08:12 AM, Pavel Hrdina wrote:
QMP command "vm-snapshot-save" has also extra optional force parameter
to specify whether replace existing snapshot or not. It also returns
information about created snapshot.
Signed-off-by: Pavel Hrdina
---
hm
On 03/29/2013 08:12 AM, Pavel Hrdina wrote:
> QMP command "vm-snapshot-save" has also extra optional force parameter
> to specify whether replace existing snapshot or not. It also returns
> information about created snapshot.
>
> Signed-off-by: Pavel Hrdina
> ---
> hmp-commands.hx | 4 +
QMP command "vm-snapshot-save" has also extra optional force parameter
to specify whether replace existing snapshot or not. It also returns
information about created snapshot.
Signed-off-by: Pavel Hrdina
---
hmp-commands.hx | 4 ++--
hmp.c | 11 +
hmp.h
