Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Cornelia Huck
On Tue, 22 Aug 2017 16:34:48 +0200 Halil Pasic wrote: > I think we are in agreement. Looking forward to v2. FWIW, here's what I currently have. I'll test a bit before sending the next version. From 45e143bd820fe9c2f4e31dcc9feb5ad324d00077 Mon Sep 17 00:00:00 2001 From: Cornelia Huck Date: Thu,

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Cornelia Huck
On Tue, 22 Aug 2017 16:27:38 +0200 Halil Pasic wrote: > On 08/22/2017 04:06 PM, Cornelia Huck wrote: > > On Tue, 22 Aug 2017 15:24:34 +0200 > > Cornelia Huck wrote: > > > >> On Tue, 22 Aug 2017 14:58:37 +0200 > >> Halil Pasic wrote: > >> > >>> On 08/22/2017 11:39 AM, Cornelia Huck wrote:

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Halil Pasic
On 08/22/2017 04:06 PM, Cornelia Huck wrote: > On Tue, 22 Aug 2017 15:24:34 +0200 > Cornelia Huck wrote: > >> On Tue, 22 Aug 2017 14:58:37 +0200 >> Halil Pasic wrote: >> >>> On 08/22/2017 11:39 AM, Cornelia Huck wrote: On Tue, 22 Aug 2017 11:20:51 +0200 Halil Pasic wrote: > >

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Halil Pasic
On 08/22/2017 04:15 PM, Cornelia Huck wrote: > On Tue, 22 Aug 2017 15:54:32 +0200 > Halil Pasic wrote: > >> On 08/22/2017 03:24 PM, Cornelia Huck wrote: >>> On Tue, 22 Aug 2017 14:58:37 +0200 >>> Halil Pasic wrote: > The availability of SCLP_CMDW_{,DE}CONFIGURE_IOA is indicated by t

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Cornelia Huck
On Tue, 22 Aug 2017 15:24:34 +0200 Cornelia Huck wrote: > On Tue, 22 Aug 2017 14:58:37 +0200 > Halil Pasic wrote: > > > On 08/22/2017 11:39 AM, Cornelia Huck wrote: > > > On Tue, 22 Aug 2017 11:20:51 +0200 > > > Halil Pasic wrote: > > >> Well, the QEMU name of the command is misleading misl

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Halil Pasic
On 08/22/2017 03:24 PM, Cornelia Huck wrote: > On Tue, 22 Aug 2017 14:58:37 +0200 > Halil Pasic wrote: > >> On 08/22/2017 11:39 AM, Cornelia Huck wrote: >>> On Tue, 22 Aug 2017 11:20:51 +0200 >>> Halil Pasic wrote: >>> On 08/22/2017 10:39 AM, Cornelia Huck wrote: >> I'm fine eith

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Cornelia Huck
On Tue, 22 Aug 2017 15:54:32 +0200 Halil Pasic wrote: > On 08/22/2017 03:24 PM, Cornelia Huck wrote: > > On Tue, 22 Aug 2017 14:58:37 +0200 > > Halil Pasic wrote: > >> The availability of SCLP_CMDW_{,DE}CONFIGURE_IOA is indicated > >> by the result of the read scp info command read info in > >>

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Cornelia Huck
On Tue, 22 Aug 2017 14:58:37 +0200 Halil Pasic wrote: > On 08/22/2017 11:39 AM, Cornelia Huck wrote: > > On Tue, 22 Aug 2017 11:20:51 +0200 > > Halil Pasic wrote: > > > >> On 08/22/2017 10:39 AM, Cornelia Huck wrote: > I'm fine either way. If I imagine having a lots of adapter types, t

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Halil Pasic
On 08/22/2017 02:57 PM, Cornelia Huck wrote: > On Tue, 22 Aug 2017 11:39:14 +0200 > Cornelia Huck wrote: > >> On Tue, 22 Aug 2017 11:20:51 +0200 >> Halil Pasic wrote: >> >>> On 08/22/2017 10:39 AM, Cornelia Huck wrote: > I'm fine either way. If I imagine having a lots of adapter types, t

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Halil Pasic
On 08/22/2017 11:39 AM, Cornelia Huck wrote: > On Tue, 22 Aug 2017 11:20:51 +0200 > Halil Pasic wrote: > >> On 08/22/2017 10:39 AM, Cornelia Huck wrote: I'm fine either way. If I imagine having a lots of adapter types, then I would expect a switch or a jumptable on the type before han

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Cornelia Huck
On Tue, 22 Aug 2017 11:39:14 +0200 Cornelia Huck wrote: > On Tue, 22 Aug 2017 11:20:51 +0200 > Halil Pasic wrote: > > > On 08/22/2017 10:39 AM, Cornelia Huck wrote: > > >> I'm fine either way. If I imagine having a lots of adapter types, then I > > >> would expect a switch or a jumptable on t

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Cornelia Huck
On Tue, 22 Aug 2017 11:20:51 +0200 Halil Pasic wrote: > On 08/22/2017 10:39 AM, Cornelia Huck wrote: > >> I'm fine either way. If I imagine having a lots of adapter types, then I > >> would expect a switch or a jumptable on the type before handling control > >> to the pci specific function. In th

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Halil Pasic
On 08/22/2017 10:39 AM, Cornelia Huck wrote: >> I'm fine either way. If I imagine having a lots of adapter types, then I >> would expect a switch or a jumptable on the type before handling control >> to the pci specific function. In this case statically not supported types >> would probably get c

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-22 Thread Cornelia Huck
On Mon, 21 Aug 2017 18:24:15 +0200 Halil Pasic wrote: > On 08/21/2017 04:58 PM, Pierre Morel wrote: > > On 21/08/2017 11:16, Cornelia Huck wrote: > >> If we do not provide zpci, pci reconfiguration via sclp is not available > >> either. Don't indicate it in the sclp facilities and return an inv

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-21 Thread Halil Pasic
On 08/21/2017 04:58 PM, Pierre Morel wrote: > On 21/08/2017 11:16, Cornelia Huck wrote: >> If we do not provide zpci, pci reconfiguration via sclp is not available >> either. Don't indicate it in the sclp facilities and return an invalid >> command if the guest tries to issue pci configure/deconf

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-21 Thread Pierre Morel
On 21/08/2017 11:16, Cornelia Huck wrote: If we do not provide zpci, pci reconfiguration via sclp is not available either. Don't indicate it in the sclp facilities and return an invalid command if the guest tries to issue pci configure/deconfigure. Reviewed-by: Thomas Huth Signed-off-by: Cornel

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-21 Thread Cornelia Huck
On Mon, 21 Aug 2017 15:32:23 +0200 Halil Pasic wrote: > On 08/21/2017 03:16 PM, Cornelia Huck wrote: > > On Mon, 21 Aug 2017 13:41:53 +0200 > > Halil Pasic wrote: > > > >> On 08/21/2017 11:16 AM, Cornelia Huck wrote: > >>> If we do not provide zpci, pci reconfiguration via sclp is not avail

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-21 Thread Halil Pasic
On 08/21/2017 03:16 PM, Cornelia Huck wrote: > On Mon, 21 Aug 2017 13:41:53 +0200 > Halil Pasic wrote: > >> On 08/21/2017 11:16 AM, Cornelia Huck wrote: >>> If we do not provide zpci, pci reconfiguration via sclp is not available >>> either. Don't indicate it in the sclp facilities and return a

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-21 Thread Cornelia Huck
On Mon, 21 Aug 2017 13:41:53 +0200 Halil Pasic wrote: > On 08/21/2017 11:16 AM, Cornelia Huck wrote: > > If we do not provide zpci, pci reconfiguration via sclp is not available > > either. Don't indicate it in the sclp facilities and return an invalid > > command if the guest tries to issue pci

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-21 Thread Halil Pasic
On 08/21/2017 11:16 AM, Cornelia Huck wrote: > If we do not provide zpci, pci reconfiguration via sclp is not available > either. Don't indicate it in the sclp facilities and return an invalid > command if the guest tries to issue pci configure/deconfigure. > > Reviewed-by: Thomas Huth > Signed

[Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-21 Thread Cornelia Huck
If we do not provide zpci, pci reconfiguration via sclp is not available either. Don't indicate it in the sclp facilities and return an invalid command if the guest tries to issue pci configure/deconfigure. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- hw/s390x/sclp.c | 19 +