Re: [Qemu-devel] [PATCH v4 05/22] qobject: Simplify qobject_from_jsonv()

2018-01-08 Thread Eric Blake
On 10/02/2017 09:30 AM, Eric Blake wrote: > On 10/02/2017 12:46 AM, Markus Armbruster wrote: > > +/* > + * This seemingly unnecessary copy is required in case va_list > + * is an array type. > + */ --verbose? > +va_copy(ap_copy, ap); > +

Re: [Qemu-devel] [PATCH v4 05/22] qobject: Simplify qobject_from_jsonv()

2017-09-11 Thread Eric Blake
On 08/03/2017 08:25 PM, Eric Blake wrote: > qobject_from_jsonv() was unusual in that it took a va_list*, instead > of the more typical va_list; this was so that callers could pass > NULL to avoid % interpolation. While this works under the hood, it > is awkward for callers, so move the magic into

Re: [Qemu-devel] [PATCH v4 05/22] qobject: Simplify qobject_from_jsonv()

2017-08-09 Thread Eric Blake
On 08/09/2017 02:59 AM, Markus Armbruster wrote: > Eric Blake writes: > >> qobject_from_jsonv() was unusual in that it took a va_list*, instead >> of the more typical va_list; this was so that callers could pass >> NULL to avoid % interpolation. While this works under the hood, it >> is awkward

Re: [Qemu-devel] [PATCH v4 05/22] qobject: Simplify qobject_from_jsonv()

2017-08-09 Thread Markus Armbruster
Eric Blake writes: > qobject_from_jsonv() was unusual in that it took a va_list*, instead > of the more typical va_list; this was so that callers could pass > NULL to avoid % interpolation. While this works under the hood, it > is awkward for callers, so move the magic into qjson.c rather than >

[Qemu-devel] [PATCH v4 05/22] qobject: Simplify qobject_from_jsonv()

2017-08-03 Thread Eric Blake
qobject_from_jsonv() was unusual in that it took a va_list*, instead of the more typical va_list; this was so that callers could pass NULL to avoid % interpolation. While this works under the hood, it is awkward for callers, so move the magic into qjson.c rather than in the public interface, and f