Re: [Qemu-devel] [PATCH v4 04/14] onenand: Switch to byte-based block access

2016-05-02 Thread Eric Blake
On 05/02/2016 03:16 PM, Eric Blake wrote: >> First of all, why signed? More importantly, though, sec is an int. I'm >> not sure if we should cast it to uint64_t before shifting (I'm unsure >> because this device seems to supports only sizes that fit in a uint32_t >> anyway), but if we don't, wouldn

Re: [Qemu-devel] [PATCH v4 04/14] onenand: Switch to byte-based block access

2016-05-02 Thread Eric Blake
On 05/02/2016 09:35 AM, Kevin Wolf wrote: > Am 29.04.2016 um 22:08 hat Eric Blake geschrieben: >> Sector-based blk_write() should die; switch to byte-based >> blk_pwrite() instead. Likewise for blk_read(). >> >> Signed-off-by: Eric Blake >> >> --- >> Not compile tested - I'm not sure what else I'

Re: [Qemu-devel] [PATCH v4 04/14] onenand: Switch to byte-based block access

2016-05-02 Thread Kevin Wolf
Am 29.04.2016 um 22:08 hat Eric Blake geschrieben: > Sector-based blk_write() should die; switch to byte-based > blk_pwrite() instead. Likewise for blk_read(). > > Signed-off-by: Eric Blake > > --- > Not compile tested - I'm not sure what else I'd need in my environment > to actually test this

[Qemu-devel] [PATCH v4 04/14] onenand: Switch to byte-based block access

2016-04-29 Thread Eric Blake
Sector-based blk_write() should die; switch to byte-based blk_pwrite() instead. Likewise for blk_read(). Signed-off-by: Eric Blake --- Not compile tested - I'm not sure what else I'd need in my environment to actually test this one. I have: Fedora 23, dnf builddep qemu ./configure --enable-kvm