Re: [Qemu-devel] [PATCH v4 03/28] qemu-img: Don't leak errors when outputting JSON

2016-06-01 Thread Markus Armbruster
Eric Blake writes: > If our JSON output ever encounters an error, we would just silently > leak the local variable. Instead, assert that our usage won't fail. Suggest "leak the error object". Can do on commit. > Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v4 03/28] qemu-img: Don't leak errors when outputting JSON

2016-05-18 Thread Eric Blake
If our JSON output ever encounters an error, we would just silently leak the local variable. Instead, assert that our usage won't fail. Signed-off-by: Eric Blake --- v4: new patch (split out from v3 14/18) --- qemu-img.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --