Re: [Qemu-devel] [PATCH v4 01/29] include: Make headers more self-contained

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/12/19 7:23 AM, Markus Armbruster wrote: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers should normally include eve

[Qemu-devel] [PATCH v4 01/29] include: Make headers more self-contained

2019-08-11 Thread Markus Armbruster
Back in 2016, we discussed[1] rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h. 2. Headers should normally include everything they need beyond osdep.h. If exceptions are need