Re: [Qemu-devel] [PATCH v4 01/18] qapi/block-core: Introduce BackupCommon

2019-07-09 Thread Markus Armbruster
John Snow writes: > On 7/9/19 7:25 PM, John Snow wrote: >> drive-backup and blockdev-backup have an awful lot of things in common >> that are the same. Let's fix that. >> >> I don't deduplicate 'target', because the semantics actually did change >> between each structure. Leave that one alone so

Re: [Qemu-devel] [PATCH v4 01/18] qapi/block-core: Introduce BackupCommon

2019-07-09 Thread John Snow
On 7/9/19 7:25 PM, John Snow wrote: > drive-backup and blockdev-backup have an awful lot of things in common > that are the same. Let's fix that. > > I don't deduplicate 'target', because the semantics actually did change > between each structure. Leave that one alone so it can be documented >

[Qemu-devel] [PATCH v4 01/18] qapi/block-core: Introduce BackupCommon

2019-07-09 Thread John Snow
drive-backup and blockdev-backup have an awful lot of things in common that are the same. Let's fix that. I don't deduplicate 'target', because the semantics actually did change between each structure. Leave that one alone so it can be documented separately. Signed-off-by: John Snow Reviewed-by: