Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-21 Thread Fam Zheng
On Mon, 02/19 13:56, Peter Maydell wrote: > On 17 February 2018 at 13:23, Alex Bennée wrote: > > Peter Maydell writes: > >> If you persuade git to use the --minimal, --patience or --histogram > >> git diff option when generating these patches you'll find that it > >> doesn't produce unreadable pa

Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-20 Thread Alex Bennée
Laurent Vivier writes: > Le 13/02/2018 à 16:51, Peter Maydell a écrit: >> On 6 February 2018 at 16:47, Alex Bennée wrote: >>> Hi, >>> >>> The main change is applying the __attribute__((flatten)) to some of >>> the public functions that show up in Emilio's dbt-benchmark. This >>> seems to be a c

Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-19 Thread Peter Maydell
On 17 February 2018 at 13:23, Alex Bennée wrote: > Peter Maydell writes: >> If you persuade git to use the --minimal, --patience or --histogram >> git diff option when generating these patches you'll find that it >> doesn't produce unreadable patches that provoke all the checkpatch >> warnings. >

Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-17 Thread Alex Bennée
Peter Maydell writes: > On 6 February 2018 at 16:47, Alex Bennée wrote: >> Hi, >> >> The main change is applying the __attribute__((flatten)) to some of >> the public functions that show up in Emilio's dbt-benchmark. This >> seems to be a cleaner solution that squashing inlines higher up the >>

Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-13 Thread Laurent Vivier
Le 13/02/2018 à 16:51, Peter Maydell a écrit : > On 6 February 2018 at 16:47, Alex Bennée wrote: >> Hi, >> >> The main change is applying the __attribute__((flatten)) to some of >> the public functions that show up in Emilio's dbt-benchmark. This >> seems to be a cleaner solution that squashing in

Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-13 Thread Peter Maydell
On 6 February 2018 at 16:47, Alex Bennée wrote: > Hi, > > The main change is applying the __attribute__((flatten)) to some of > the public functions that show up in Emilio's dbt-benchmark. This > seems to be a cleaner solution that squashing inlines higher up the > chain and still leaves the chanc

Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-13 Thread Peter Maydell
On 6 February 2018 at 16:47, Alex Bennée wrote: > Hi, > > The main change is applying the __attribute__((flatten)) to some of > the public functions that show up in Emilio's dbt-benchmark. This > seems to be a cleaner solution that squashing inlines higher up the > chain and still leaves the chanc

Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-07 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180206164815.10084-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions === TEST SCRIPT BEGIN === #!/bin/bash BASE

[Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-06 Thread Alex Bennée
Hi, The main change is applying the __attribute__((flatten)) to some of the public functions that show up in Emilio's dbt-benchmark. This seems to be a cleaner solution that squashing inlines higher up the chain and still leaves the chance for re-use for the less widely used functions. The results