Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-16 Thread Wenchao Xia
于 2013-4-11 1:33, Pavel Hrdina 写道: On 10.4.2013 19:15, Eric Blake wrote: On 04/10/2013 08:05 AM, Pavel Hrdina wrote: Here is another proposal how to handle vm snapshots: QMP vm-snapshot-save: - { 'command': 'vm-snapshot-save', 'data': { 'name': 'str' }, 'returns': 'Snaps

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-15 Thread Eric Blake
On 04/15/2013 06:10 AM, Kevin Wolf wrote: > Am 11.04.2013 um 11:20 hat Markus Armbruster geschrieben: >> [Cc: Wenchao Xia because of overlap with his work] >> >> Eric Blake writes: >> >>> On 04/10/2013 08:05 AM, Pavel Hrdina wrote: Here is another proposal how to handle vm snapshots: >>>

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-15 Thread Kevin Wolf
Am 11.04.2013 um 11:20 hat Markus Armbruster geschrieben: > [Cc: Wenchao Xia because of overlap with his work] > > Eric Blake writes: > > > On 04/10/2013 08:05 AM, Pavel Hrdina wrote: > >> Here is another proposal how to handle vm snapshots: > >> > >> QMP vm-snapshot-save: > >> - { 'command

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-11 Thread Markus Armbruster
[Cc: Wenchao Xia because of overlap with his work] Eric Blake writes: > On 04/10/2013 08:05 AM, Pavel Hrdina wrote: >> Here is another proposal how to handle vm snapshots: >> >> QMP vm-snapshot-save: >> - { 'command': 'vm-snapshot-save', >> 'data': { 'name': 'str' }, >> 'ret

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Pavel Hrdina
On 10.4.2013 19:15, Eric Blake wrote: On 04/10/2013 08:05 AM, Pavel Hrdina wrote: Here is another proposal how to handle vm snapshots: QMP vm-snapshot-save: - { 'command': 'vm-snapshot-save', 'data': { 'name': 'str' }, 'returns': 'SnapshotInfo' } - vm-snapshot-save r

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Eric Blake
On 04/10/2013 08:05 AM, Pavel Hrdina wrote: > Here is another proposal how to handle vm snapshots: > > QMP vm-snapshot-save: > - { 'command': 'vm-snapshot-save', > 'data': { 'name': 'str' }, > 'returns': 'SnapshotInfo' } > - vm-snapshot-save returns an error if there is an

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Pavel Hrdina
Here is another proposal how to handle vm snapshots: QMP vm-snapshot-save: - { 'command': 'vm-snapshot-save', 'data': { 'name': 'str' }, 'returns': 'SnapshotInfo' } - vm-snapshot-save returns an error if there is an existing snapshot with the same name - you cann

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Pavel Hrdina
On 10.4.2013 15:32, Luiz Capitulino wrote: On Wed, 10 Apr 2013 15:22:49 +0200 Pavel Hrdina wrote: On 10.4.2013 14:49, Eric Blake wrote: On 04/10/2013 06:40 AM, Luiz Capitulino wrote: On Wed, 10 Apr 2013 06:24:11 -0600 Eric Blake wrote: - If you want to overwrite an existing snapshot,

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Luiz Capitulino
On Wed, 10 Apr 2013 15:22:49 +0200 Pavel Hrdina wrote: > On 10.4.2013 14:49, Eric Blake wrote: > > On 04/10/2013 06:40 AM, Luiz Capitulino wrote: > >> On Wed, 10 Apr 2013 06:24:11 -0600 > >> Eric Blake wrote: > >> > - If you want to overwrite an existing snapshot, you could specify > >>>

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Pavel Hrdina
On 10.4.2013 14:49, Eric Blake wrote: On 04/10/2013 06:40 AM, Luiz Capitulino wrote: On Wed, 10 Apr 2013 06:24:11 -0600 Eric Blake wrote: - If you want to overwrite an existing snapshot, you could specify the 'id' or the 'name' argument or both of them and also you will have to u

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Eric Blake
On 04/10/2013 06:40 AM, Luiz Capitulino wrote: > On Wed, 10 Apr 2013 06:24:11 -0600 > Eric Blake wrote: > >>> - If you want to overwrite an existing snapshot, you could specify >>> the 'id' or the 'name' argument or both of them and also you will >>> have to use the 'force' argument >>

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Luiz Capitulino
On Wed, 10 Apr 2013 06:24:11 -0600 Eric Blake wrote: > > - If you want to overwrite an existing snapshot, you could specify > > the 'id' or the 'name' argument or both of them and also you will > > have to use the 'force' argument > > But the argument made in this thread is that QMP sh

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Eric Blake
On 04/10/2013 04:53 AM, Pavel Hrdina wrote: > The first thing what we should discuss is the use of name as tak or > id. I think that the best solution should be that we will have separate > arguments of both. We will use the 'name' argument to specify the tag > of a snapshot and we will add a new a

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Pavel Hrdina
On 10.4.2013 10:18, Markus Armbruster wrote: Pavel Hrdina writes: This patch series convert the savevm command into qapi and introduce QMP command vm-snapshot-save. It also rewrite error report for functions used by this command. The last patch introduce new functionality of savevm that you c

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Markus Armbruster
Pavel Hrdina writes: > This patch series convert the savevm command into qapi and introduce QMP > command vm-snapshot-save. > It also rewrite error report for functions used by this command. > > The last patch introduce new functionality of savevm that you cannot override > existing snapshot with

[Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-03-29 Thread Pavel Hrdina
This patch series convert the savevm command into qapi and introduce QMP command vm-snapshot-save. It also rewrite error report for functions used by this command. The last patch introduce new functionality of savevm that you cannot override existing snapshot without using 'force' parameter. If n