Re: [Qemu-devel] [PATCH v4 00/10] initial spice support.

2010-08-31 Thread Anthony Liguori
On 08/31/2010 04:54 AM, Gerd Hoffmann wrote: Hi, But for the most part, people agree that we want braces to be used on single line ifs. Ok. Got a bunch of incremental fixes committed locally. How to go forward now? Want me to respin or can I send those codestyle fixups as part of the n

Re: [Qemu-devel] [PATCH v4 00/10] initial spice support.

2010-08-31 Thread Gerd Hoffmann
Hi, But for the most part, people agree that we want braces to be used on single line ifs. Ok. Got a bunch of incremental fixes committed locally. How to go forward now? Want me to respin or can I send those codestyle fixups as part of the next spice patch series? BTW: what is the pla

Re: [Qemu-devel] [PATCH v4 00/10] initial spice support.

2010-08-30 Thread Blue Swirl
On Mon, Aug 30, 2010 at 7:32 PM, Gerd Hoffmann wrote: > On 08/30/10 21:02, Anthony Liguori wrote: >> >> On 08/30/2010 01:58 PM, Blue Swirl wrote: >>> >>> Wilful misconduct? May I ask if there are other things that you don't >>> agree with and you are covertly working against? > > I'm just not used

Re: [Qemu-devel] [PATCH v4 00/10] initial spice support.

2010-08-30 Thread Gerd Hoffmann
On 08/30/10 21:02, Anthony Liguori wrote: On 08/30/2010 01:58 PM, Blue Swirl wrote: Wilful misconduct? May I ask if there are other things that you don't agree with and you are covertly working against? I'm just not used to it. Changing habits takes time. I think I became better meanwhile o

Re: [Qemu-devel] [PATCH v4 00/10] initial spice support.

2010-08-30 Thread Anthony Liguori
On 08/30/2010 01:58 PM, Blue Swirl wrote: Wilful misconduct? May I ask if there are other things that you don't agree with and you are covertly working against? :-) Braces should be used. The discussion was about enforcing coding style at commit time and reformatting code. But for the

Re: [Qemu-devel] [PATCH v4 00/10] initial spice support.

2010-08-30 Thread Blue Swirl
On Mon, Aug 30, 2010 at 8:48 AM, Gerd Hoffmann wrote: > On 08/28/10 08:42, Blue Swirl wrote: >> >> On Fri, Aug 27, 2010 at 9:59 AM, Gerd Hoffmann  wrote: >>> >>>  Hi, >>> >>> Here comes v4 of the iniial spice support patch series, hopefully the >>> final version.  It brings just the very basic bit

Re: [Qemu-devel] [PATCH v4 00/10] initial spice support.

2010-08-30 Thread Gerd Hoffmann
On 08/28/10 08:42, Blue Swirl wrote: On Fri, Aug 27, 2010 at 9:59 AM, Gerd Hoffmann wrote: Hi, Here comes v4 of the iniial spice support patch series, hopefully the final version. It brings just the very basic bits: * Detect spice in configure, Makefile windup. * Support for keyboard,

Re: [Qemu-devel] [PATCH v4 00/10] initial spice support.

2010-08-27 Thread Blue Swirl
On Fri, Aug 27, 2010 at 9:59 AM, Gerd Hoffmann wrote: >  Hi, > > Here comes v4 of the iniial spice support patch series, hopefully the > final version.  It brings just the very basic bits: > >  * Detect spice in configure, Makefile windup. >  * Support for keyboard, mouse and tablet. >  * Support

[Qemu-devel] [PATCH v4 00/10] initial spice support.

2010-08-27 Thread Gerd Hoffmann
Hi, Here comes v4 of the iniial spice support patch series, hopefully the final version. It brings just the very basic bits: * Detect spice in configure, Makefile windup. * Support for keyboard, mouse and tablet. * Support for simple display output (works as DisplayChangeListener, plays