Re: [Qemu-devel] [PATCH v4 0/9] 8bit AVR cores

2016-06-06 Thread Richard Henderson
On 06/06/2016 12:49 PM, Michael Rolnik wrote: please advise. I have the following warning. but all print_instn_XXX functions are declared this way. so, I am kind of confused. I can fix it, but the file won't look the same. WARNING: space prohibited between function name and open parenthesis '('

Re: [Qemu-devel] [PATCH v4 0/9] 8bit AVR cores

2016-06-06 Thread Richard Henderson
On 06/06/2016 12:53 PM, Michael Rolnik wrote: WARNING: architecture specific defines should be avoided #574: FILE: target-avr/cpu.h:32: +#if !defined(__CPU_AVR_H__) it was not my invention, I took it from either target-alpha or target-ppc. Let's not introduce any more mistakes. Follow target-

Re: [Qemu-devel] [PATCH v4 0/9] 8bit AVR cores

2016-06-06 Thread Michael Rolnik
WARNING: architecture specific defines should be avoided #574: FILE: target-avr/cpu.h:32: +#if !defined(__CPU_AVR_H__) it was not my invention, I took it from either target-alpha or target-ppc. On Mon, Jun 6, 2016 at 10:49 PM, Michael Rolnik wrote: > please advise. > I have the following warnin

Re: [Qemu-devel] [PATCH v4 0/9] 8bit AVR cores

2016-06-06 Thread Michael Rolnik
please advise. I have the following warning. but all print_instn_XXX functions are declared this way. so, I am kind of confused. I can fix it, but the file won't look the same. WARNING: space prohibited between function name and open parenthesis '(' #132: FILE: include/disas/bfd.h:424: +int print_

Re: [Qemu-devel] [PATCH v4 0/9] 8bit AVR cores

2016-06-06 Thread Richard Henderson
On 06/06/2016 03:37 AM, Michael Rolnik wrote: changes since v3 1. rampD/X/Y/Z registers are encoded as 0x00ff and not 0x00ff for faster address manipulaton 2. ffs changed to ctz32 3. duplicate code removed at avr_cpu_do_interrupt 4. using andc instead of not + and 5. fixing V flag calcul

[Qemu-devel] [PATCH v4 0/9] 8bit AVR cores

2016-06-06 Thread Michael Rolnik
This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support yet