Re: [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug

2014-06-17 Thread Amos Kong
On Wed, Jun 18, 2014 at 10:58:52AM +0800, Amos Kong wrote: > On Tue, Jun 17, 2014 at 03:37:08PM +0200, Andreas Färber wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > Hi Amos, > > > > Am 17.06.2014 14:54, schrieb Amos Kong: > > > On Mon, Jun 09, 2014 at 03:22:51PM +0200, Stefa

Re: [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug

2014-06-17 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 10:58 AM, Amos Kong wrote: > On Tue, Jun 17, 2014 at 03:37:08PM +0200, Andreas Färber wrote: >> That said, I've reviewed the generic qtest part OK, and would assume >> virtio-blk-test (you can drop the .c in the topic please) to go >> through the same tree virtio-blk does,

Re: [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug

2014-06-17 Thread Amos Kong
On Tue, Jun 17, 2014 at 03:37:08PM +0200, Andreas Färber wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi Amos, > > Am 17.06.2014 14:54, schrieb Amos Kong: > > On Mon, Jun 09, 2014 at 03:22:51PM +0200, Stefan Hajnoczi wrote: > >> On Fri, Jun 06, 2014 at 10:33:49PM +0800, Amos Kong

Re: [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug

2014-06-17 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Amos, Am 17.06.2014 14:54, schrieb Amos Kong: > On Mon, Jun 09, 2014 at 03:22:51PM +0200, Stefan Hajnoczi wrote: >> On Fri, Jun 06, 2014 at 10:33:49PM +0800, Amos Kong wrote: >>> It's worth to add a hotplug test to qtest, but without >>> cooperati

Re: [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug

2014-06-17 Thread Amos Kong
On Mon, Jun 09, 2014 at 03:22:51PM +0200, Stefan Hajnoczi wrote: > On Fri, Jun 06, 2014 at 10:33:49PM +0800, Amos Kong wrote: > > It's worth to add a hotplug test to qtest, but without > > cooperation of guest OS, new devices can't be initialized > > by guest, and hot-unplug doesn't work. > > > >

Re: [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug

2014-06-09 Thread Stefan Hajnoczi
On Fri, Jun 06, 2014 at 10:33:49PM +0800, Amos Kong wrote: > It's worth to add a hotplug test to qtest, but without > cooperation of guest OS, new devices can't be initialized > by guest, and hot-unplug doesn't work. > > However, the new test can cover some part of code of > hotplug/unplug. > > I

[Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug

2014-06-06 Thread Amos Kong
It's worth to add a hotplug test to qtest, but without cooperation of guest OS, new devices can't be initialized by guest, and hot-unplug doesn't work. However, the new test can cover some part of code of hotplug/unplug. I will write another subtest to test hotplug with pci support. V2: move qmp