Re: [Qemu-devel] [PATCH v4 0/2] trace: Trace control commands

2014-09-24 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 01:19:51PM +0200, Lluís Vilanova wrote: > Adds QAPI/QMP commands to control tracing events, and reimplements some of the > related HMP commands on top. > > NOTE: The "trace-event-set-state" command uses a bool 'enable' argument > instead > of an enum 'state'. I'm sti

Re: [Qemu-devel] [PATCH v4 0/2] trace: Trace control commands

2014-09-08 Thread Luiz Capitulino
On Mon, 08 Sep 2014 15:03:41 -0500 Lluís Vilanova wrote: > Lluís Vilanova writes: > > > Adds QAPI/QMP commands to control tracing events, and reimplements some of > > the > > related HMP commands on top. > > Ping. I need reviewers. Stefan and Eric are obvious candidates.

Re: [Qemu-devel] [PATCH v4 0/2] trace: Trace control commands

2014-09-08 Thread Lluís Vilanova
Lluís Vilanova writes: > Adds QAPI/QMP commands to control tracing events, and reimplements some of the > related HMP commands on top. Ping. Thanks, Lluis > NOTE: The "trace-event-set-state" command uses a bool 'enable' argument > instead > of an enum 'state'. I'm still not sure if a

[Qemu-devel] [PATCH v4 0/2] trace: Trace control commands

2014-08-25 Thread Lluís Vilanova
Adds QAPI/QMP commands to control tracing events, and reimplements some of the related HMP commands on top. NOTE: The "trace-event-set-state" command uses a bool 'enable' argument instead of an enum 'state'. I'm still not sure if an enum is better than the two separate booleans. Signe