Re: [Qemu-devel] [PATCH v4] vhost: fix log base address

2015-04-20 Thread Peter Maydell
On 20 April 2015 at 07:07, Michael S. Tsirkin wrote: > On Fri, Apr 17, 2015 at 05:13:24PM +0200, Michael S. Tsirkin wrote: >> VHOST_SET_LOG_BASE got an incorrect address, causing >> migration errors and potentially even memory corruption. >> >> Reported-by: Wen Congyang >> Signed-off-by: Michael

Re: [Qemu-devel] [PATCH v4] vhost: fix log base address

2015-04-19 Thread Michael S. Tsirkin
On Fri, Apr 17, 2015 at 05:13:24PM +0200, Michael S. Tsirkin wrote: > VHOST_SET_LOG_BASE got an incorrect address, causing > migration errors and potentially even memory corruption. > > Reported-by: Wen Congyang > Signed-off-by: Michael S. Tsirkin > --- OK, this passed testing now. Peter, can y

Re: [Qemu-devel] [PATCH v4] vhost: fix log base address

2015-04-19 Thread Amos Kong
On Fri, Apr 17, 2015 at 05:13:24PM +0200, Michael S. Tsirkin wrote: > VHOST_SET_LOG_BASE got an incorrect address, causing > migration errors and potentially even memory corruption. > > Reported-by: Wen Congyang > Signed-off-by: Michael S. Tsirkin > --- > > changed (uint64_t)(unsigned long) to

Re: [Qemu-devel] [PATCH v4] vhost: fix log base address

2015-04-17 Thread 幽灵王子
At 2015/4/17 23:13, Michael S. Tsirkin Wrote: VHOST_SET_LOG_BASE got an incorrect address, causing migration errors and potentially even memory corruption. Reported-by: Wen Congyang Signed-off-by: Michael S. Tsirkin --- changed (uint64_t)(unsigned long) to (uintptr_t). Untested. Wen Congyang

[Qemu-devel] [PATCH v4] vhost: fix log base address

2015-04-17 Thread Michael S. Tsirkin
VHOST_SET_LOG_BASE got an incorrect address, causing migration errors and potentially even memory corruption. Reported-by: Wen Congyang Signed-off-by: Michael S. Tsirkin --- changed (uint64_t)(unsigned long) to (uintptr_t). Untested. Wen Congyang, can you pls test and confirm. hw/virtio/vhost