Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu

2015-05-12 Thread Gerd Hoffmann
Hi, > We *could* do it that way, but it wouldn't look pretty. Instead of having > these menu items: > > VGA, Monitor, Serial, Parallel > > We would have these menu items: > > VGA > compat_monitor0 > serial0 > parallel0 > > They look very anti-pretty. Those (except VGA) come from the charde

Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu

2015-05-11 Thread Peter Maydell
On 11 May 2015 at 15:38, Programmingkid wrote: > On May 11, 2015, at 10:33 AM, Peter Maydell wrote: >> They're the menu entries we have in the GTK UI. If you want >> pretty names then you should fix this in the common code >> so that any UI that wants to display pretty names can do >> that. Having

Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu

2015-05-11 Thread Programmingkid
On May 11, 2015, at 10:33 AM, Peter Maydell wrote: > On 11 May 2015 at 15:29, Programmingkid wrote: >> >> On May 11, 2015, at 9:20 AM, Peter Maydell wrote: >>> Can't we just create a menu with an item for every console, >>> and set its menu text to the result of qemu_console_get_label() ? >>> I

Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu

2015-05-11 Thread Peter Maydell
On 11 May 2015 at 15:29, Programmingkid wrote: > > On May 11, 2015, at 9:20 AM, Peter Maydell wrote: >> Can't we just create a menu with an item for every console, >> and set its menu text to the result of qemu_console_get_label() ? >> I don't see why we need to special case these four and only >>

Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu

2015-05-11 Thread Programmingkid
On May 11, 2015, at 9:20 AM, Peter Maydell wrote: > On 11 May 2015 at 01:32, Programmingkid wrote: >> This patch adds the VGA, Monitor, Serial, and Parallel menu item to the view >> menu. >> >> Signed-off-by: John Arbuckle > >> +// set the console variables for the consoles we have >> +

Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu

2015-05-11 Thread Peter Maydell
On 11 May 2015 at 01:32, Programmingkid wrote: > This patch adds the VGA, Monitor, Serial, and Parallel menu item to the view > menu. > > Signed-off-by: John Arbuckle > +// set the console variables for the consoles we have > +while(qemu_console_lookup_by_index(index) != NULL) { > +

[Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu

2015-05-10 Thread Programmingkid
This patch adds the VGA, Monitor, Serial, and Parallel menu item to the view menu. Signed-off-by: John Arbuckle --- Removed all code added in console.c. Used existing console code in place of new console code. Added several console global variables to keep track of usable consoles. Simplified