Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-07 Thread Luiz Capitulino
On Fri, 07 Jun 2013 16:01:34 -0500 Anthony Liguori wrote: > Luiz Capitulino writes: > > > On Fri, 7 Jun 2013 09:56:00 -0500 > > mdroth wrote: > > > >> On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: > >> > On Tue, 4 Jun 2013 16:35:09 -0500 > >> > Michael Roth wrote: > >> >

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-07 Thread Anthony Liguori
Luiz Capitulino writes: > On Fri, 7 Jun 2013 09:56:00 -0500 > mdroth wrote: > >> On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: >> > On Tue, 4 Jun 2013 16:35:09 -0500 >> > Michael Roth wrote: >> > >> > > When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, >> >

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-07 Thread mdroth
On Fri, Jun 07, 2013 at 11:36:16AM -0400, Luiz Capitulino wrote: > On Fri, 7 Jun 2013 09:56:00 -0500 > mdroth wrote: > > > On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: > > > On Tue, 4 Jun 2013 16:35:09 -0500 > > > Michael Roth wrote: > > > > > > > When CHR_EVENT_OPENED was

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-07 Thread Luiz Capitulino
On Fri, 7 Jun 2013 09:56:00 -0500 mdroth wrote: > On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: > > On Tue, 4 Jun 2013 16:35:09 -0500 > > Michael Roth wrote: > > > > > When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, > > > and it was issued as a bottom-half

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-07 Thread mdroth
On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: > On Tue, 4 Jun 2013 16:35:09 -0500 > Michael Roth wrote: > > > When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, > > and it was issued as a bottom-half: > > > > 86e94dea5b740dad65446c857f6959eae43e0ba6 > > > > W

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-07 Thread Luiz Capitulino
On Tue, 4 Jun 2013 16:35:09 -0500 Michael Roth wrote: > When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, > and it was issued as a bottom-half: > > 86e94dea5b740dad65446c857f6959eae43e0ba6 > > Which we basically used to print out a greeting/prompt for the > monitor. > > AFAIC

[Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-04 Thread Michael Roth
When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, and it was issued as a bottom-half: 86e94dea5b740dad65446c857f6959eae43e0ba6 Which we basically used to print out a greeting/prompt for the monitor. AFAICT the only reason this was ever done in a BH was because in some cases we'd