Re: [Qemu-devel] [PATCH v4] qapi: Add InetSocketAddress member keep-alive

2019-07-29 Thread Eric Blake
On 7/25/19 4:49 AM, Vladimir Sementsov-Ogievskiy wrote: > It's needed to provide keepalive for nbd client to track server > availability. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > +++ b/util/qemu-sockets.c > @@ -219,6 +219,12 @@ static int inet_listen_saddr(InetSocketAddress *saddr

Re: [Qemu-devel] [PATCH v4] qapi: Add InetSocketAddress member keep-alive

2019-07-25 Thread Markus Armbruster
Eric Blake writes: > On 7/25/19 10:26 AM, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> It's needed to provide keepalive for nbd client to track server >>> availability. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >> >> Reviewed-by: Markus Armbruster > > It

Re: [Qemu-devel] [PATCH v4] qapi: Add InetSocketAddress member keep-alive

2019-07-25 Thread Daniel P . Berrangé
On Thu, Jul 25, 2019 at 11:38:56AM -0500, Eric Blake wrote: > On 7/25/19 10:26 AM, Markus Armbruster wrote: > > Vladimir Sementsov-Ogievskiy writes: > > > >> It's needed to provide keepalive for nbd client to track server > >> availability. > >> > >> Signed-off-by: Vladimir Sementsov-Ogievskiy >

Re: [Qemu-devel] [PATCH v4] qapi: Add InetSocketAddress member keep-alive

2019-07-25 Thread Eric Blake
On 7/25/19 10:26 AM, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> It's needed to provide keepalive for nbd client to track server >> availability. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy > > Reviewed-by: Markus Armbruster It looks like this could go in any nu

Re: [Qemu-devel] [PATCH v4] qapi: Add InetSocketAddress member keep-alive

2019-07-25 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > It's needed to provide keepalive for nbd client to track server > availability. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH v4] qapi: Add InetSocketAddress member keep-alive

2019-07-25 Thread Vladimir Sementsov-Ogievskiy
It's needed to provide keepalive for nbd client to track server availability. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Notes: v4; [by Markus's comments] - use "passive socket" term - move check for not enabled keep_alive to inet_listen_saddr() v3: [by Markus's co