Re: [Qemu-devel] [PATCH v4] ps2: migrate ledstate

2011-11-01 Thread Anthony Liguori
On 10/17/2011 06:37 AM, Juan Quintela wrote: From: Christophe Fergeau Make the ps2 device track its ledstate so that we can migrate it. Otherwise it gets lost across migration, and spice-server gets confused about the actual keyboard state and sends bogus caps/scroll/num key events. This fixes R

Re: [Qemu-devel] [PATCH v4] ps2: migrate ledstate

2011-10-17 Thread Anthony Liguori
On 10/17/2011 10:15 AM, Gerd Hoffmann wrote: Hi, We only need to migrate the state when it is different of the default one (0). Er, isn't it going to be different from the default in like 99% of circumstances? Why? caps lock and scroll lock are off usually. numlock depends on what the user

Re: [Qemu-devel] [PATCH v4] ps2: migrate ledstate

2011-10-17 Thread Juan Quintela
Gerd Hoffmann wrote: > Hi, > >>> We only need to migrate the state when it is different of the default >>> one (0). >> >> Er, isn't it going to be different from the default in like 99% of >> circumstances? > > Why? caps lock and scroll lock are off usually. numlock depends on > what the user

Re: [Qemu-devel] [PATCH v4] ps2: migrate ledstate

2011-10-17 Thread Gerd Hoffmann
Hi, We only need to migrate the state when it is different of the default one (0). Er, isn't it going to be different from the default in like 99% of circumstances? Why? caps lock and scroll lock are off usually. numlock depends on what the user prefers. In case he cares in the first

Re: [Qemu-devel] [PATCH v4] ps2: migrate ledstate

2011-10-17 Thread Anthony Liguori
On 10/17/2011 06:37 AM, Juan Quintela wrote: From: Christophe Fergeau Make the ps2 device track its ledstate so that we can migrate it. Otherwise it gets lost across migration, and spice-server gets confused about the actual keyboard state and sends bogus caps/scroll/num key events. This fixes R

Re: [Qemu-devel] [PATCH v4] ps2: migrate ledstate

2011-10-17 Thread Christophe Fergeau
Hey, On Mon, Oct 17, 2011 at 01:37:34PM +0200, Juan Quintela wrote: > Make the ps2 device track its ledstate so that we can migrate it. > Otherwise it gets lost across migration, and spice-server gets > confused about the actual keyboard state and sends bogus > caps/scroll/num key events. This fix

[Qemu-devel] [PATCH v4] ps2: migrate ledstate

2011-10-17 Thread Juan Quintela
From: Christophe Fergeau Make the ps2 device track its ledstate so that we can migrate it. Otherwise it gets lost across migration, and spice-server gets confused about the actual keyboard state and sends bogus caps/scroll/num key events. This fixes RH bug #729294 We only need to migrate the sta