Re: [Qemu-devel] [PATCH v4] integrator: fix Linux boot failure by emulating dbg region

2013-10-26 Thread Alex Bennée
peter.mayd...@linaro.org writes: > On 22 October 2013 15:16, wrote: >> +typedef struct { >> +SysBusDevice parent_obj; >> + >> +MemoryRegion iomem; >> + >> +uint32_t alpha; >> +uint32_t leds; >> +uint32_t switches; >> +} IntegratorDebugState > > You forgot to remove these unu

Re: [Qemu-devel] [PATCH v4] integrator: fix Linux boot failure by emulating dbg region

2013-10-25 Thread Peter Maydell
On 22 October 2013 15:16, wrote: > +typedef struct { > +SysBusDevice parent_obj; > + > +MemoryRegion iomem; > + > +uint32_t alpha; > +uint32_t leds; > +uint32_t switches; > +} IntegratorDebugState You forgot to remove these unused fields. I've done so and added that slightly-

[Qemu-devel] [PATCH v4] integrator: fix Linux boot failure by emulating dbg region

2013-10-22 Thread alex . bennee
From: Alex Bennée Commit 9b8c69243 (since reverted) broke the ability to boot the kernel as the value returned by unassigned_mem_read returned non-zero and left the kernel looping forever waiting for it to change (see integrator_led_set in the kernel code). Relying on a varying implementation de