Re: [Qemu-devel] [PATCH v4] hw/unicore32: remove wrong assertion in puv machine init

2017-03-30 Thread Marcel Apfelbaum
On 03/30/2017 07:34 PM, Suramya Shah wrote: Hi, Much better now, only a nit.. Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error.Assert should not be used to check user provided parameters. Report an error and exit instead You should break the

[Qemu-devel] [PATCH v4] hw/unicore32: remove wrong assertion in puv machine init

2017-03-30 Thread Suramya Shah
Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error.Assert should not be used to check user provided parameters. Report an error and exit instead Signed-off-by: Suramya Shah --- hw/unicore32/puv3.c | 7 +-- 1 file changed, 5 insertions(+), 2 d