Re: [Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables

2017-09-08 Thread Daniel P. Berrange
On Fri, Sep 08, 2017 at 07:23:52PM +0800, Fam Zheng wrote: > On Fri, 09/08 12:00, Daniel P. Berrange wrote: > > On Fri, Sep 08, 2017 at 06:58:53PM +0800, Fam Zheng wrote: > > > If you don't like introducing {nettle,gcrypt,gnutls}.mo for now, we can > > > probably > > > defer it to the time when cr

Re: [Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables

2017-09-08 Thread Fam Zheng
On Fri, 09/08 12:00, Daniel P. Berrange wrote: > On Fri, Sep 08, 2017 at 06:58:53PM +0800, Fam Zheng wrote: > > On Fri, 09/08 11:36, Daniel P. Berrange wrote: > > > On Fri, Sep 08, 2017 at 06:27:01PM +0800, Fam Zheng wrote: > > > > On Fri, 09/08 11:05, Daniel P. Berrange wrote: > > > > > On Wed, Se

Re: [Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables

2017-09-08 Thread Daniel P. Berrange
On Fri, Sep 08, 2017 at 06:58:53PM +0800, Fam Zheng wrote: > On Fri, 09/08 11:36, Daniel P. Berrange wrote: > > On Fri, Sep 08, 2017 at 06:27:01PM +0800, Fam Zheng wrote: > > > On Fri, 09/08 11:05, Daniel P. Berrange wrote: > > > > On Wed, Sep 06, 2017 at 08:49:00PM +0800, Fam Zheng wrote: > > > >

Re: [Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables

2017-09-08 Thread Fam Zheng
On Fri, 09/08 11:36, Daniel P. Berrange wrote: > On Fri, Sep 08, 2017 at 06:27:01PM +0800, Fam Zheng wrote: > > On Fri, 09/08 11:05, Daniel P. Berrange wrote: > > > On Wed, Sep 06, 2017 at 08:49:00PM +0800, Fam Zheng wrote: > > > > This patch groups the crypto objects into a few .mo objects based o

Re: [Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables

2017-09-08 Thread Daniel P. Berrange
On Fri, Sep 08, 2017 at 06:27:01PM +0800, Fam Zheng wrote: > On Fri, 09/08 11:05, Daniel P. Berrange wrote: > > On Wed, Sep 06, 2017 at 08:49:00PM +0800, Fam Zheng wrote: > > > This patch groups the crypto objects into a few .mo objects based on > > > functional submodules, and moves inclusion cond

Re: [Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables

2017-09-08 Thread Fam Zheng
On Fri, 09/08 11:05, Daniel P. Berrange wrote: > On Wed, Sep 06, 2017 at 08:49:00PM +0800, Fam Zheng wrote: > > This patch groups the crypto objects into a few .mo objects based on > > functional submodules, and moves inclusion conditions to *-objs > > variables, then moves the global cflags/libs t

Re: [Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables

2017-09-08 Thread Daniel P. Berrange
On Wed, Sep 06, 2017 at 08:49:00PM +0800, Fam Zheng wrote: > This patch groups the crypto objects into a few .mo objects based on > functional submodules, and moves inclusion conditions to *-objs > variables, then moves the global cflags/libs to the *-cflags and *-libs > variables. > > For init.o

Re: [Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables

2017-09-07 Thread Fam Zheng
On Fri, 09/08 14:31, Fam Zheng wrote: > On Wed, 09/06 20:49, Fam Zheng wrote: > > This patch groups the crypto objects into a few .mo objects based on > > functional submodules, and moves inclusion conditions to *-objs > > variables, then moves the global cflags/libs to the *-cflags and *-libs > >

Re: [Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables

2017-09-07 Thread Fam Zheng
On Wed, 09/06 20:49, Fam Zheng wrote: > This patch groups the crypto objects into a few .mo objects based on > functional submodules, and moves inclusion conditions to *-objs > variables, then moves the global cflags/libs to the *-cflags and *-libs > variables. > > For init.o and cipher.o, which m

[Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables

2017-09-06 Thread Fam Zheng
This patch groups the crypto objects into a few .mo objects based on functional submodules, and moves inclusion conditions to *-objs variables, then moves the global cflags/libs to the *-cflags and *-libs variables. For init.o and cipher.o, which may or may not need the library flags depending on