Re: [Qemu-devel] [PATCH v4] block: fix QEMU crash with scsi-hd and drive_del

2018-06-26 Thread Max Reitz
On 2018-06-26 21:30, Max Reitz wrote: > On 2018-05-28 14:03, Greg Kurz wrote: >> Removing a drive with drive_del while it is being used to run an I/O >> intensive workload can cause QEMU to crash. >> >> An AIO flush can yield at some point: >> >> blk_aio_flush_entry() >> blk_co_flush(blk) >> bdr

Re: [Qemu-devel] [PATCH v4] block: fix QEMU crash with scsi-hd and drive_del

2018-06-26 Thread Max Reitz
On 2018-05-28 14:03, Greg Kurz wrote: > Removing a drive with drive_del while it is being used to run an I/O > intensive workload can cause QEMU to crash. > > An AIO flush can yield at some point: > > blk_aio_flush_entry() > blk_co_flush(blk) > bdrv_co_flush(blk->root->bs) >... > qemu_

Re: [Qemu-devel] [PATCH v4] block: fix QEMU crash with scsi-hd and drive_del

2018-05-29 Thread Greg Kurz
On Tue, 29 May 2018 22:19:17 +0200 Kevin Wolf wrote: > Am 28.05.2018 um 14:03 hat Greg Kurz geschrieben: > > Removing a drive with drive_del while it is being used to run an I/O > > intensive workload can cause QEMU to crash. > > > > An AIO flush can yield at some point: > > > > blk_aio_flush_e

Re: [Qemu-devel] [PATCH v4] block: fix QEMU crash with scsi-hd and drive_del

2018-05-29 Thread Kevin Wolf
Am 28.05.2018 um 14:03 hat Greg Kurz geschrieben: > Removing a drive with drive_del while it is being used to run an I/O > intensive workload can cause QEMU to crash. > > An AIO flush can yield at some point: > > blk_aio_flush_entry() > blk_co_flush(blk) > bdrv_co_flush(blk->root->bs) >...

Re: [Qemu-devel] [PATCH v4] block: fix QEMU crash with scsi-hd and drive_del

2018-05-29 Thread Kevin Wolf
Am 28.05.2018 um 14:03 hat Greg Kurz geschrieben: > Removing a drive with drive_del while it is being used to run an I/O > intensive workload can cause QEMU to crash. > > An AIO flush can yield at some point: > > blk_aio_flush_entry() > blk_co_flush(blk) > bdrv_co_flush(blk->root->bs) >...

[Qemu-devel] [PATCH v4] block: fix QEMU crash with scsi-hd and drive_del

2018-05-28 Thread Greg Kurz
Removing a drive with drive_del while it is being used to run an I/O intensive workload can cause QEMU to crash. An AIO flush can yield at some point: blk_aio_flush_entry() blk_co_flush(blk) bdrv_co_flush(blk->root->bs) ... qemu_coroutine_yield() and let the HMP command to run, free bl