06.07.2015 19:45, Peter Crosthwaite пишет:
As someone who doesn't send PULLs, I still find patches very useful.
It sanity checks your email sends. A while back, I drafted a paragraph
on how to use patches to verify receipt of your series if we want to
add it to "submit a patch".
Sounds useful.
On Mon, Jul 6, 2015 at 6:38 AM, Dmitry Osipenko wrote:
> 06.07.2015 16:16, Peter Maydell пишет:
>>>
>>> Probably, I should go and try those tools myself to have better sense of
>>> what I should and shouldn't be doing.
>>
>>
>> The particular one I find useful is Anthony Liguori's "patches"
>> too
06.07.2015 16:16, Peter Maydell пишет:
Probably, I should go and try those tools myself to have better sense of
what I should and shouldn't be doing.
The particular one I find useful is Anthony Liguori's "patches"
tool: https://github.com/aliguori/patches
Thanks! I'll take a look at it.
But
On 6 July 2015 at 14:11, Dmitry Osipenko wrote:
> I made a quick glance at "SubmitAPatch" before posting. Now, reading more
> closely, I see that it all mentioned there and I feel sorry for that.
No problem -- it's a pretty big page and it mentions a lot of
different things. (I keep meaning to tr
06.07.2015 12:23, Peter Maydell пишет:
If you need to update a patch, please resend the whole series,
not just one patch from it. (This is one of the things we talk
about on http://wiki.qemu.org/Contribute/SubmitAPatch -- the
v2/3/4 etc version number applies to a series, not a single
I made a
On 6 July 2015 at 02:27, Dmitry Osipenko wrote:
> The timer should fire the interrupt only if the IT (interrupt enable) bit
> state of the control register is enabled.
>
> Signed-off-by: Dmitry Osipenko
> Reviewed-by: Peter Crosthwaite
If you need to update a patch, please resend the whole seri
The timer should fire the interrupt only if the IT (interrupt enable) bit
state of the control register is enabled.
Signed-off-by: Dmitry Osipenko
Reviewed-by: Peter Crosthwaite
---
v2: Added missed IRQ status update on control register write as per
Peter Crosthwaite comment.
v3: No code c
