Re: [Qemu-devel] [PATCH v4] arm_mptimer: Convert to use ptimer

2015-10-13 Thread Dmitry Osipenko
13.10.2015 18:38, Dmitry Osipenko пишет: 13.10.2015 17:11, Dmitry Osipenko пишет: +ptimer_set_limit(tb->timer, value, 0); +ptimer_set_count(tb->timer, value); Umm... looking more at these lines, I think it might put in a trouble in some corner case. It might worth trying to ma

Re: [Qemu-devel] [PATCH v4] arm_mptimer: Convert to use ptimer

2015-10-13 Thread Dmitry Osipenko
13.10.2015 17:11, Dmitry Osipenko пишет: +ptimer_set_limit(tb->timer, value, 0); +ptimer_set_count(tb->timer, value); Umm... looking more at these lines, I think it might put in a trouble in some corner case. It might worth trying to make ptimer more flexible rather than to w

[Qemu-devel] [PATCH v4] arm_mptimer: Convert to use ptimer

2015-10-13 Thread Dmitry Osipenko
Current ARM MPTimer implementation uses QEMUTimer for the actual timer, this implementation isn't complete and mostly tries to duplicate of what generic ptimer is already doing fine. Conversion to ptimer brings the following benefits and fixes: - Simple timer pausing implementation