Re: [Qemu-devel] [PATCH v3 for-2.9] virtio: fix vring_align() on 64-bit windows

2017-03-28 Thread Stefan Weil
Am 28.03.2017 um 22:11 schrieb Michael S. Tsirkin: I'm doing a pull request a bit later today - I can pick this one up if you prefer. If yes, pls send your ack. Yes, please. Thanks a lot Stefan

Re: [Qemu-devel] [PATCH v3 for-2.9] virtio: fix vring_align() on 64-bit windows

2017-03-28 Thread Michael S. Tsirkin
On Tue, Mar 28, 2017 at 10:02:10PM +0200, Stefan Weil wrote: > Am 28.03.2017 um 20:56 schrieb Andrew Baumann: > > > From: Eric Blake [mailto:ebl...@redhat.com] > > > Sent: Tuesday, 28 March 2017 11:52 > > > > > > On 03/28/2017 01:38 PM, Stefan Weil wrote: > > > > Am 25.03.2017 um 00:19 schrieb And

Re: [Qemu-devel] [PATCH v3 for-2.9] virtio: fix vring_align() on 64-bit windows

2017-03-28 Thread Stefan Weil
Am 28.03.2017 um 20:56 schrieb Andrew Baumann: From: Eric Blake [mailto:ebl...@redhat.com] Sent: Tuesday, 28 March 2017 11:52 On 03/28/2017 01:38 PM, Stefan Weil wrote: Am 25.03.2017 um 00:19 schrieb Andrew Baumann: long is 32-bits on 64-bit windows, which caused the top half of the address to

Re: [Qemu-devel] [PATCH v3 for-2.9?] virtio: fix vring_align() on 64-bit windows

2017-03-28 Thread Stefan Weil
Am 28.03.2017 um 20:56 schrieb Andrew Baumann: From: Eric Blake [mailto:ebl...@redhat.com] Is this needed for 2.9? Yes, it's a correctness bug that avoids miscompilation on 64-bit targets where long is 32 bits (which, at the moment, is really just Windows). I agree, this should be in 2.9. I

Re: [Qemu-devel] [PATCH v3 for-2.9?] virtio: fix vring_align() on 64-bit windows

2017-03-28 Thread Philippe Mathieu-Daudé
Hi, I never received Andrew Baumann's mail via the ML... On 03/28/2017 03:38 PM, Stefan Weil wrote: Am 25.03.2017 um 00:19 schrieb QEMU_ALIGN_UP: long is 32-bits on 64-bit windows, which caused the top half of the address to be truncated; this patch changes it to use the QEMU_ALIGN_UP macro whi

Re: [Qemu-devel] [PATCH v3 for-2.9?] virtio: fix vring_align() on 64-bit windows

2017-03-28 Thread Andrew Baumann via Qemu-devel
> From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, 28 March 2017 11:52 > > On 03/28/2017 01:38 PM, Stefan Weil wrote: > > Am 25.03.2017 um 00:19 schrieb Andrew Baumann: > >> long is 32-bits on 64-bit windows, which caused the top half of the > >> address to be truncated; this patch cha

Re: [Qemu-devel] [PATCH v3 for-2.9?] virtio: fix vring_align() on 64-bit windows

2017-03-28 Thread Eric Blake
On 03/28/2017 01:38 PM, Stefan Weil wrote: > Am 25.03.2017 um 00:19 schrieb Andrew Baumann: >> long is 32-bits on 64-bit windows, which caused the top half of the >> address to be truncated; this patch changes it to use the >> QEMU_ALIGN_UP macro which does not suffer the same problem >> >> Signed-

Re: [Qemu-devel] [PATCH v3 for-2.9?] virtio: fix vring_align() on 64-bit windows

2017-03-28 Thread Stefan Weil
Am 25.03.2017 um 00:19 schrieb Andrew Baumann: long is 32-bits on 64-bit windows, which caused the top half of the address to be truncated; this patch changes it to use the QEMU_ALIGN_UP macro which does not suffer the same problem Signed-off-by: Andrew Baumann Reviewed-by: Eric Blake --- inc