Re: [Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler

2017-10-18 Thread Dong Jia Shi
* Halil Pasic [2017-10-18 13:01:03 +0200]: > > > On 10/18/2017 12:02 PM, Cornelia Huck wrote: > > On Wed, 18 Oct 2017 12:00:05 +0200 > > Thomas Huth wrote: > > > >> On 17.10.2017 16:04, Halil Pasic wrote: > >>> Simplify the error handling of the MSCH. Let the code detecting the > >>> conditi

Re: [Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler

2017-10-18 Thread Halil Pasic
On 10/18/2017 12:02 PM, Cornelia Huck wrote: > On Wed, 18 Oct 2017 12:00:05 +0200 > Thomas Huth wrote: > >> On 17.10.2017 16:04, Halil Pasic wrote: >>> Simplify the error handling of the MSCH. Let the code detecting the >>> condition tell (in a less ambiguous way) how it's to be handled. No >>

Re: [Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler

2017-10-18 Thread Cornelia Huck
On Wed, 18 Oct 2017 12:00:05 +0200 Thomas Huth wrote: > On 17.10.2017 16:04, Halil Pasic wrote: > > Simplify the error handling of the MSCH. Let the code detecting the > > condition tell (in a less ambiguous way) how it's to be handled. No > > changes in behavior. > > ok, so you claim no chan

Re: [Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler

2017-10-18 Thread Thomas Huth
On 17.10.2017 16:04, Halil Pasic wrote: > Simplify the error handling of the MSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. ok, so you claim no changes in behavior ... > Signed-off-by: Halil Pasic > --- > hw/s390x/c

Re: [Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler

2017-10-17 Thread Cornelia Huck
On Tue, 17 Oct 2017 16:04:53 +0200 Halil Pasic wrote: > Simplify the error handling of the MSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 18 +

[Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler

2017-10-17 Thread Halil Pasic
Simplify the error handling of the MSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic --- hw/s390x/css.c | 18 +- include/hw/s390x/css.h | 2 +- target/s390x/ioinst.c | 23