Re: [Qemu-devel] [PATCH v3 7/7] block/dirty-bitmaps: implement inconsistent bit

2019-03-08 Thread John Snow
On 3/7/19 11:37 AM, Eric Blake wrote: > On 3/6/19 3:46 PM, John Snow wrote: > >>> I think, inconsistent bitmaps should have readonly flag always set or >>> always unset, independently on can_write, >>> as we are not going to write something related to inconsistent bitmaps. >>> >> >> We'll neve

Re: [Qemu-devel] [PATCH v3 7/7] block/dirty-bitmaps: implement inconsistent bit

2019-03-07 Thread Eric Blake
On 3/6/19 3:46 PM, John Snow wrote: >> I think, inconsistent bitmaps should have readonly flag always set or always >> unset, independently on can_write, >> as we are not going to write something related to inconsistent bitmaps. >> > > We'll never change metadata for inconsistent bitmaps, no. We

Re: [Qemu-devel] [PATCH v3 7/7] block/dirty-bitmaps: implement inconsistent bit

2019-03-06 Thread John Snow
On 3/6/19 9:26 AM, Vladimir Sementsov-Ogievskiy wrote: > 01.03.2019 22:15, John Snow wrote: >> Set the inconsistent bit on load instead of rejecting such bitmaps. >> There is no way to un-set it; the only option is to delete it. > > I think, s/delete it/delete the bitmap/, as "it" is the bit af

Re: [Qemu-devel] [PATCH v3 7/7] block/dirty-bitmaps: implement inconsistent bit

2019-03-06 Thread Vladimir Sementsov-Ogievskiy
01.03.2019 22:15, John Snow wrote: > Set the inconsistent bit on load instead of rejecting such bitmaps. > There is no way to un-set it; the only option is to delete it. I think, s/delete it/delete the bitmap/, as "it" is the bit after "un-set it". > > Obvervations: > - bitmap loading does not n

Re: [Qemu-devel] [PATCH v3 7/7] block/dirty-bitmaps: implement inconsistent bit

2019-03-01 Thread Eric Blake
On 3/1/19 1:15 PM, John Snow wrote: > Set the inconsistent bit on load instead of rejecting such bitmaps. > There is no way to un-set it; the only option is to delete it. > > Obvervations: > - bitmap loading does not need to update the header for in_use bitmaps. > - inconsistent bitmaps don't need

[Qemu-devel] [PATCH v3 7/7] block/dirty-bitmaps: implement inconsistent bit

2019-03-01 Thread John Snow
Set the inconsistent bit on load instead of rejecting such bitmaps. There is no way to un-set it; the only option is to delete it. Obvervations: - bitmap loading does not need to update the header for in_use bitmaps. - inconsistent bitmaps don't need to have their data loaded; they're glorified