Re: [Qemu-devel] [PATCH v3 6/7] cpu: add device_add foo-x86_64-cpu support

2015-02-05 Thread Chen Fan
On 01/30/2015 12:39 AM, Andreas Färber wrote: Am 29.01.2015 um 17:01 schrieb Eduardo Habkost: On Thu, Jan 29, 2015 at 03:46:03PM +0100, Igor Mammedov wrote: [...] @@ -2742,7 +2776,14 @@ static void x86_cpu_apic_create(X86CPU *cpu, Error **errp) object_property_add_child(OBJECT(cpu),

Re: [Qemu-devel] [PATCH v3 6/7] cpu: add device_add foo-x86_64-cpu support

2015-01-29 Thread Andreas Färber
Am 29.01.2015 um 17:01 schrieb Eduardo Habkost: > On Thu, Jan 29, 2015 at 03:46:03PM +0100, Igor Mammedov wrote: > [...] >>> @@ -2742,7 +2776,14 @@ static void x86_cpu_apic_create(X86CPU *cpu, Error >>> **errp) >>> >>> object_property_add_child(OBJECT(cpu), "apic", >>>

Re: [Qemu-devel] [PATCH v3 6/7] cpu: add device_add foo-x86_64-cpu support

2015-01-29 Thread Eduardo Habkost
On Thu, Jan 29, 2015 at 03:46:03PM +0100, Igor Mammedov wrote: [...] > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > index 3406fe8..4347948 100644 > > --- a/target-i386/cpu.c > > +++ b/target-i386/cpu.c > > @@ -1705,6 +1705,7 @@ static void x86_cpuid_set_apic_id(Object *obj, > > Visitor

Re: [Qemu-devel] [PATCH v3 6/7] cpu: add device_add foo-x86_64-cpu support

2015-01-29 Thread Igor Mammedov
On Wed, 14 Jan 2015 15:27:29 +0800 Zhu Guihua wrote: > From: Chen Fan > > Add support to device_add foo-x86_64-cpu, and additional checks of > apic id are added into x86_cpuid_set_apic_id() to avoid duplicate. > Besides, in order to support "device/device_add foo-x86_64-cpu" > which without spe

[Qemu-devel] [PATCH v3 6/7] cpu: add device_add foo-x86_64-cpu support

2015-01-13 Thread Zhu Guihua
From: Chen Fan Add support to device_add foo-x86_64-cpu, and additional checks of apic id are added into x86_cpuid_set_apic_id() to avoid duplicate. Besides, in order to support "device/device_add foo-x86_64-cpu" which without specified apic id, we assign cpuid_apic_id with a default broadcast va