On Thu, Jan 5, 2012 at 1:48 PM, Stefan Hajnoczi wrote:
>>> + /* Base device not supported */
>>> + if (base) {
>>> + error_set(errp, QERR_NOT_SUPPORTED);
>>> + return;
>>> + }
>>
>> Is this a future feature? In this case I'd rather drop the argument for
>> now and add it lat
On Wed, Jan 4, 2012 at 12:59 PM, Luiz Capitulino wrote:
> On Tue, 13 Dec 2011 13:52:27 +
> Stefan Hajnoczi wrote:
>
>> Add the block_stream command, which starts copy backing file contents
>> into the image file. Later patches add control over the background copy
>> speed, cancelation, and q
By the way, most of my review comments applies to the other commands being
added in this series:
- Use verbs and separate word with hyphens
- Follow the documentation syntax (see other commands for examples)
- Use the hmp_handle_error() helper
- Drop any SQMP/EQMP documentation
On Tue, 13 Dec 2011 13:52:27 +
Stefan Hajnoczi wrote:
> Add the block_stream command, which starts copy backing file contents
> into the image file. Later patches add control over the background copy
> speed, cancelation, and querying running streaming operations.
Please also mention that y
Add the block_stream command, which starts copy backing file contents
into the image file. Later patches add control over the background copy
speed, cancelation, and querying running streaming operations.
Signed-off-by: Stefan Hajnoczi
---
blockdev.c | 68 +++
