Re: [Qemu-devel] [PATCH v3 5/8] qdev: Register static properties as class properties

2016-10-29 Thread Igor Mammedov
On Thu, 27 Oct 2016 14:37:28 -0200 Eduardo Habkost wrote: > On Thu, Oct 27, 2016 at 05:30:30PM +0200, Igor Mammedov wrote: > [...] > > > > "make V=1 check" fails for me with this patch applied: > > > > > > > > QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64 > > > > QTEST_QEMU_IMG=qemu-img

Re: [Qemu-devel] [PATCH v3 5/8] qdev: Register static properties as class properties

2016-10-27 Thread Eduardo Habkost
On Thu, Oct 27, 2016 at 05:30:30PM +0200, Igor Mammedov wrote: [...] > > > "make V=1 check" fails for me with this patch applied: > > > > > > QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64 > > > QTEST_QEMU_IMG=qemu-img MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % > > > 255 + 1))} gteste

Re: [Qemu-devel] [PATCH v3 5/8] qdev: Register static properties as class properties

2016-10-27 Thread Igor Mammedov
On Thu, 27 Oct 2016 12:57:42 -0200 Eduardo Habkost wrote: > On Thu, Oct 27, 2016 at 04:51:39PM +0200, Igor Mammedov wrote: > > On Wed, 26 Oct 2016 14:30:23 -0200 > > Eduardo Habkost wrote: > > > > > Instead of registering qdev static properties on instance_init, > > > register them as class p

Re: [Qemu-devel] [PATCH v3 5/8] qdev: Register static properties as class properties

2016-10-27 Thread Eduardo Habkost
On Thu, Oct 27, 2016 at 04:51:39PM +0200, Igor Mammedov wrote: > On Wed, 26 Oct 2016 14:30:23 -0200 > Eduardo Habkost wrote: > > > Instead of registering qdev static properties on instance_init, > > register them as class properties, at qdev_class_set_props(). > > > > qdev_property_add_legacy()

Re: [Qemu-devel] [PATCH v3 5/8] qdev: Register static properties as class properties

2016-10-27 Thread Igor Mammedov
On Wed, 26 Oct 2016 14:30:23 -0200 Eduardo Habkost wrote: > Instead of registering qdev static properties on instance_init, > register them as class properties, at qdev_class_set_props(). > > qdev_property_add_legacy() was replaced by an equivalent > qdev_class_property_add_legacy() function. >

[Qemu-devel] [PATCH v3 5/8] qdev: Register static properties as class properties

2016-10-26 Thread Eduardo Habkost
Instead of registering qdev static properties on instance_init, register them as class properties, at qdev_class_set_props(). qdev_property_add_legacy() was replaced by an equivalent qdev_class_property_add_legacy() function. qdev_property_add_static(), on the other hand, can't be eliminated yet b