Re: [Qemu-devel] [PATCH v3 5/7] s390x: refactor error handling for CSCH handler

2017-10-19 Thread Cornelia Huck
On Thu, 19 Oct 2017 14:14:45 +0800 Dong Jia Shi wrote: > * Halil Pasic [2017-10-17 16:04:51 +0200]: > > > Simplify the error handling of the cSCH. Let the code detecting the > > condition tell (in a less ambiguous way) how it's to be handled. No > > changes in behavior. > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH v3 5/7] s390x: refactor error handling for CSCH handler

2017-10-18 Thread Dong Jia Shi
* Halil Pasic [2017-10-17 16:04:51 +0200]: > Simplify the error handling of the cSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- [...] > diff --git a/target/s390x/ioinst.c b/targe

Re: [Qemu-devel] [PATCH v3 5/7] s390x: refactor error handling for CSCH handler

2017-10-18 Thread Thomas Huth
On 17.10.2017 16:04, Halil Pasic wrote: > Simplify the error handling of the cSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 12 +++- > include/h

Re: [Qemu-devel] [PATCH v3 5/7] s390x: refactor error handling for CSCH handler

2017-10-17 Thread Cornelia Huck
On Tue, 17 Oct 2017 16:04:51 +0200 Halil Pasic wrote: > Simplify the error handling of the cSCH. Let the code detecting the s/cSCH/CSCH/ > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c

[Qemu-devel] [PATCH v3 5/7] s390x: refactor error handling for CSCH handler

2017-10-17 Thread Halil Pasic
Simplify the error handling of the cSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic --- hw/s390x/css.c | 12 +++- include/hw/s390x/css.h | 2 +- target/s390x/ioinst.c | 14 -