Re: [Qemu-devel] [PATCH v3 5/7] Add vhost-user calls implementation

2013-12-16 Thread Luke Gorrie
Cool stuff :-) some thoughts: On 13 December 2013 12:14, Antonios Motakis wrote: > static int vhost_user_recv(int fd, VhostUserMsg *msg) > { > ssize_t r = read(fd, msg, sizeof(VhostUserMsg)); Is it worth considering a "timeout and reconnect" check here? I mean so that if the vhost server

[Qemu-devel] [PATCH v3 5/7] Add vhost-user calls implementation

2013-12-13 Thread Antonios Motakis
Each ioctl request of vhost-kernel has a vhost-user message equivalent, which is sent it over the control socket. The general approach is to copy the data from the supplied argument pointer to a designated field in the message. If a file descriptor is to be passed it should be placed also in the f