Re: [Qemu-devel] [PATCH v3 5/6] monitor: adding info tb and tbs to monitor

2019-07-09 Thread Dr. David Alan Gilbert
* vandersonmr (vanderson...@gmail.com) wrote: > adding options to list tbs by some metric and > investigate their code. > > Signed-off-by: Vanderson M. do Rosario As Markus said you need a short justification that it's for debug etc to justify HMP only; it doesn't need to be huge, but we should

Re: [Qemu-devel] [PATCH v3 5/6] monitor: adding info tb and tbs to monitor

2019-07-07 Thread Marc-André Lureau
Hi On Sat, Jul 6, 2019 at 10:09 AM Markus Armbruster wrote: > > Cc: Marc-André, who has patches that might be useful here. > > Alex Bennée writes: > > > Markus Armbruster writes: > > > >> vandersonmr writes: > >> > > > > > > I'll leave Vanderson to address your other comments. > > > >> > >> D

Re: [Qemu-devel] [PATCH v3 5/6] monitor: adding info tb and tbs to monitor

2019-07-07 Thread Vanderson Martins do Rosario
Markus, Thank you for your comments! Based on your questions and suggestions of writing a more complete explanation in my commits, I decided to start to describe our whole work on the wiki: https://wiki.qemu.org/Internships/ProjectIdeas/TCGCodeQuality I will update and expand it weekly, so I can l

Re: [Qemu-devel] [PATCH v3 5/6] monitor: adding info tb and tbs to monitor

2019-07-05 Thread Markus Armbruster
Cc: Marc-André, who has patches that might be useful here. Alex Bennée writes: > Markus Armbruster writes: > >> vandersonmr writes: >> > > > I'll leave Vanderson to address your other comments. > >> >> Debugging commands are kind of borderline. Debugging is commonly a >> human activity, wher

Re: [Qemu-devel] [PATCH v3 5/6] monitor: adding info tb and tbs to monitor

2019-07-05 Thread Alex Bennée
Markus Armbruster writes: > vandersonmr writes: > I'll leave Vanderson to address your other comments. > > Debugging commands are kind of borderline. Debugging is commonly a > human activity, where HMP is just fine. However, humans create tools to > assist with their activities, and then

Re: [Qemu-devel] [PATCH v3 5/6] monitor: adding info tb and tbs to monitor

2019-07-05 Thread Markus Armbruster
vandersonmr writes: > adding options to list tbs by some metric and > investigate their code. What's "tbs"? Why is listing them useful? What do you mean by "some metric"? What do you mean by "and investigate their code?" > Signed-off-by: Vanderson M. do Rosario > --- > hmp-commands-info.hx

Re: [Qemu-devel] [PATCH v3 5/6] monitor: adding info tb and tbs to monitor

2019-07-04 Thread Alex Bennée
vandersonmr writes: > adding options to list tbs by some metric and > investigate their code. > > Signed-off-by: Vanderson M. do Rosario > --- > hmp-commands-info.hx | 22 ++ > monitor/misc.c | 69 > 2 files changed, 91 insertions

[Qemu-devel] [PATCH v3 5/6] monitor: adding info tb and tbs to monitor

2019-07-02 Thread vandersonmr
adding options to list tbs by some metric and investigate their code. Signed-off-by: Vanderson M. do Rosario --- hmp-commands-info.hx | 22 ++ monitor/misc.c | 69 2 files changed, 91 insertions(+) diff --git a/hmp-commands-info.hx