On Thu, Aug 16, 2018 at 10:26:18AM +0200, Markus Armbruster wrote:
>> On Thu, Aug 16, 2018 at 07:43:41AM +0200, Markus Armbruster wrote:
On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote:
> Also, had you considered rearranging and making them optional,
> for exampl
Simon Ruderich writes:
> On Thu, Aug 16, 2018 at 07:43:41AM +0200, Markus Armbruster wrote:
>>> On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote:
Also, had you considered rearranging and making them optional,
for example if you do:
val:l,filename:F,offset
On Thu, Aug 16, 2018 at 07:43:41AM +0200, Markus Armbruster wrote:
>> On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote:
>>> Also, had you considered rearranging and making them optional,
>>> for example if you do:
>>>
>>> val:l,filename:F,offset:i?,size:i?
>>>
>>> I think that
Simon Ruderich writes:
> On Wed, Aug 15, 2018 at 04:29:25PM +0200, Markus Armbruster wrote:
>>> For the HMP or the QMP interface?
>>
>> Both.
>
> Ok.
>
>>> If you think 'offset' is not necessary I can also drop it
>>> completely.
>>
>> I think it's a reasonable feature, and since you already code
On Wed, Aug 15, 2018 at 04:29:25PM +0200, Markus Armbruster wrote:
>> For the HMP or the QMP interface?
>
> Both.
Ok.
>> If you think 'offset' is not necessary I can also drop it
>> completely.
>
> I think it's a reasonable feature, and since you already coded it up...
In that case, should size
Simon Ruderich writes:
> On Wed, Aug 15, 2018 at 06:22:51AM +0200, Markus Armbruster wrote:
>>> My initial patch didn't have the offset. It was suggested by Eric
>>> Blake in <0a960aa8-2a3f-8667-3d46-cecf8e65e...@redhat.com>:
>>>
>>> On Tue, Apr 10, 2018 at 04:33:03PM -0500, Eric Blake wrote:
>>>
On Wed, Aug 15, 2018 at 06:22:51AM +0200, Markus Armbruster wrote:
>> My initial patch didn't have the offset. It was suggested by Eric
>> Blake in <0a960aa8-2a3f-8667-3d46-cecf8e65e...@redhat.com>:
>>
>> On Tue, Apr 10, 2018 at 04:33:03PM -0500, Eric Blake wrote:
>>> Do you additionally need an of
Simon Ruderich writes:
> On Tue, Aug 14, 2018 at 05:49:12PM +0200, Markus Armbruster wrote:
>>> On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote:
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
>>
>> Subject claims "qmp: add", but the patch also adds to hmp. Recomme
* Simon Ruderich (si...@ruderich.org) wrote:
> On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote:
> >> --- a/hmp-commands.hx
> >> +++ b/hmp-commands.hx
> >> @@ -822,6 +822,20 @@ STEXI
> >> @item pmemsave @var{addr} @var{size} @var{file}
> >> @findex pmemsave
> >> save to dis
On Tue, Aug 14, 2018 at 05:49:12PM +0200, Markus Armbruster wrote:
>> On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote:
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
>
> Subject claims "qmp: add", but the patch also adds to hmp. Recommend to
> split the patch into QMP
Simon Ruderich writes:
> On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote:
>>> --- a/hmp-commands.hx
>>> +++ b/hmp-commands.hx
Subject claims "qmp: add", but the patch also adds to hmp. Recommend to
split the patch into QMP and HMP part.
>>> @@ -822,6 +822,20 @@ STEXI
>>>
On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote:
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -822,6 +822,20 @@ STEXI
>> @item pmemsave @var{addr} @var{size} @var{file}
>> @findex pmemsave
>> save to disk physical memory dump starting at @var{addr} of size @var{
On Thu, Aug 09, 2018 at 11:46:50AM -0500, Eric Blake wrote:
> There was no 2.13 release, and this feature has missed the 3.0 deadlines, so
> it would need to say 'Since: 3.1'
Will do.
Regards
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
sig
* Simon Ruderich (si...@ruderich.org) wrote:
> Adapted patch from Baojun Wang [1] with the following commit message:
>
> I found this could be useful to have qemu-softmmu as a cross
> debugger (launch with -s -S command line option), then if we can
> have a command to load guest physic
On 05/21/2018 10:36 AM, Simon Ruderich wrote:
Adapted patch from Baojun Wang [1] with the following commit message:
I found this could be useful to have qemu-softmmu as a cross
debugger (launch with -s -S command line option), then if we can
have a command to load guest physical m
Adapted patch from Baojun Wang [1] with the following commit message:
I found this could be useful to have qemu-softmmu as a cross
debugger (launch with -s -S command line option), then if we can
have a command to load guest physical memory, we can use cross gdb
to do some target d
16 matches
Mail list logo
