Re: [Qemu-devel] [PATCH v3 5/5] fw_cfg: replace ioport data read with generic method

2015-11-03 Thread Laszlo Ersek
On 11/03/15 01:35, Gabriel L. Somlo wrote: > IOPort read access is limited to one byte at a time by > fw_cfg_comb_valid(). As such, fw_cfg_comb_read() may safely > ignore its size argument (which will always be 1), and simply > call its fw_cfg_read() helper function once, returning 8 bits > via the

[Qemu-devel] [PATCH v3 5/5] fw_cfg: replace ioport data read with generic method

2015-11-02 Thread Gabriel L. Somlo
IOPort read access is limited to one byte at a time by fw_cfg_comb_valid(). As such, fw_cfg_comb_read() may safely ignore its size argument (which will always be 1), and simply call its fw_cfg_read() helper function once, returning 8 bits via the least significant byte of a 64-bit return value. Th