Re: [Qemu-devel] [PATCH v3 44/46] ivshmem: remove EventfdEntry.vector

2015-09-22 Thread Marc-André Lureau
Hi On Tue, Sep 22, 2015 at 4:59 PM, Claudio Fontana wrote: > This one does not seem particularly valuable to me.. btw isn't it slightly > easier to debug with the vector in the structure? Yeah, it's just is a bit superflous to me store the vector index in all the elements. You get the vector i

Re: [Qemu-devel] [PATCH v3 44/46] ivshmem: remove EventfdEntry.vector

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:08, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > No need to store an extra int for the vector number when it can be > computed easily by looking at the position in the array. > > Signed-off-by: Marc-André Lureau This one does not seem particularly valuable t

[Qemu-devel] [PATCH v3 44/46] ivshmem: remove EventfdEntry.vector

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau No need to store an extra int for the vector number when it can be computed easily by looking at the position in the array. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/misc/ivshmem